Refactor BasePolarisCatalog to use Iceberg's BadRequestException instead of jakarta #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of jakarta It looks like the jakarta flavor inadvertently got added by someone's IDE and now there's a needless mix of jakarta/iceberg BadRequestException
dennishuo
requested review from
eric-maynard,
collado-mike and
ebyhr
as code owners
ebyhr
approved these changes
Sep 26, 2024
eric-maynard
approved these changes
Sep 26, 2024
dennishuo
deleted the
dhuo-remote-jakarta-bad-request-exception-from-base-catalog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like the jakarta flavor inadvertently got added by someone's IDE and now there's a needless mix of jakarta/iceberg BadRequestException
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Please delete options that are not relevant.