Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing changes for eclipselink #118

Closed
wants to merge 2 commits into from

Conversation

MonkeyCanCode
Copy link
Contributor

Description

Seems like some changes got missing after switch from build logic from Groovy to Kotlin

Fixes 47

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Same as #47

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue
  • I have signed and submitted the ICLA and if needed, the CCLA. See Contributing for details.

@MonkeyCanCode MonkeyCanCode requested a review from a team as a code owner August 8, 2024 06:53
@MonkeyCanCode
Copy link
Contributor Author

MonkeyCanCode commented Aug 8, 2024

@snazy @collado-mike maybe duplicated of #114 as the change was intensional? But "implementation(libs.h2)" is still needed to add h2 lib for default persistent backend.

@@ -90,7 +90,7 @@ defaultRealms:
metaStoreManager:
type: in-memory
# type: eclipse-link # uncomment to use eclipse-link as metastore
# persistence-unit: polaris
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally keep this to be polaris rather than polaris-dev. polaris-dev is used in test and polaris is used for production.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, if we have persistence.xml from test resource and production resource, we are loading the one from test resource.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Let me revert this one...but I don't think we will need this PR as the change is intensional based off https://github.com/polaris-catalog/polaris/pull/114/files. I think the only thing that is missing there is h2 lib import. Let me close this one and use 114 to add that in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@collado-mike close this one and added comment in your PR for including h2 lib if people ant to use default persist backend with h2.

@MonkeyCanCode MonkeyCanCode mentioned this pull request Aug 15, 2024
13 tasks
@MonkeyCanCode MonkeyCanCode deleted the add_eclipse_link branch December 12, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants