Avoid string concat for logger (#130)

apache · Aug 9, 2024 · da9717d · da9717d
1 parent 379537f
commit da9717d
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/...src/test/java/io/polaris/service/storage/azure/AzureCredentialStorageIntegrationTest.java b/...src/test/java/io/polaris/service/storage/azure/AzureCredentialStorageIntegrationTest.java
@@ -70,7 +70,7 @@ public class AzureCredentialStorageIntegrationTest {
 
   private boolean checkEnvNullVariables() {
     if (Strings.isNullOrEmpty(clientId) || Strings.isNullOrEmpty(clientSecret)) {
-      LOGGER.debug("Null Azure testing environment variables! Skip " + this.getClass().getName());
+      LOGGER.debug("Null Azure testing environment variables! Skip {}", this.getClass().getName());
       return true;
     }
     return false;

diff --git a/...re/src/test/java/io/polaris/service/storage/gcp/GcpCredentialsStorageIntegrationTest.java b/...re/src/test/java/io/polaris/service/storage/gcp/GcpCredentialsStorageIntegrationTest.java
@@ -69,8 +69,8 @@ class GcpCredentialsStorageIntegrationTest {
   public void testSubscope(boolean allowedListAction) throws IOException {
     if (Strings.isNullOrEmpty(gcsServiceKeyJsonFileLocation)) {
       LOGGER.debug(
-          "Environment variable GOOGLE_APPLICATION_CREDENTIALS not exits, skip test "
-              + getClass().getName());
+          "Environment variable GOOGLE_APPLICATION_CREDENTIALS not exits, skip test {}",
+          getClass().getName());
       return;
     }
     List<String> allowedRead =

diff --git a/...is-service/src/main/java/io/polaris/service/context/SqlliteCallContextCatalogFactory.java b/...is-service/src/main/java/io/polaris/service/context/SqlliteCallContextCatalogFactory.java
@@ -83,7 +83,7 @@ public Catalog createCallContextCatalog(
       String catalogFile = Paths.get(realmDir, catalogName).toString();
 
       // Ensure parent directories of metastore-state base directory exists.
-      LOG.info("Creating metastore state directory: " + realmDir);
+      LOG.info("Creating metastore state directory: {}", realmDir);
       try {
         Path result = Files.createDirectories(FileSystems.getDefault().getPath(realmDir));
       } catch (IOException ioe) {

diff --git a/polaris-service/src/test/java/io/polaris/service/PolarisApplicationIntegrationTest.java b/polaris-service/src/test/java/io/polaris/service/PolarisApplicationIntegrationTest.java
@@ -420,7 +420,7 @@ public void testIcebergDropNamespaceInExternalCatalog(TestInfo testInfo) throws
         sessionCatalog.loadNamespaceMetadata(sessionContext, ns);
         Assertions.fail("Expected exception when loading namespace after drop");
       } catch (NoSuchNamespaceException e) {
-        LOGGER.info("Received expected exception " + e.getMessage());
+        LOGGER.info("Received expected exception {}", e.getMessage());
       }
     }
   }
@@ -446,7 +446,7 @@ public void testIcebergCreateTablesInExternalCatalog(TestInfo testInfo) throws I
             .create();
         Assertions.fail("Expected failure calling create table in external catalog");
       } catch (BadRequestException e) {
-        LOGGER.info("Received expected exception " + e.getMessage());
+        LOGGER.info("Received expected exception {}", e.getMessage());
       }
     }
   }
@@ -497,7 +497,7 @@ public void testIcebergCreateTablesWithWritePathBlocked(TestInfo testInfo) throw
             .hasMessage(
                 "Forbidden: Delegate access to table with user-specified write location is temporarily not supported.");
       } catch (BadRequestException e) {
-        LOGGER.info("Received expected exception " + e.getMessage());
+        LOGGER.info("Received expected exception {}", e.getMessage());
       }
     }
   }
@@ -598,7 +598,7 @@ public void testIcebergUpdateTableInExternalCatalog(TestInfo testInfo) throws IO
             .commit();
         Assertions.fail("Should fail when committing an update to external catalog");
       } catch (BadRequestException e) {
-        LOGGER.info("Received expected exception " + e.getMessage());
+        LOGGER.info("Received expected exception {}", e.getMessage());
       }
     }
   }
@@ -646,7 +646,7 @@ public void testIcebergDropTableInExternalCatalog(TestInfo testInfo) throws IOEx
         sessionCatalog.loadTable(sessionContext, tableIdentifier);
         Assertions.fail("Expected failure loading table after drop");
       } catch (NoSuchTableException e) {
-        LOGGER.info("Received expected exception " + e.getMessage());
+        LOGGER.info("Received expected exception {}", e.getMessage());
       }
     }
   }

diff --git a/polaris-service/src/test/java/io/polaris/service/test/PolarisConnectionExtension.java b/polaris-service/src/test/java/io/polaris/service/test/PolarisConnectionExtension.java
@@ -185,8 +185,8 @@ static PolarisPrincipalSecrets getAdminSecrets() {
     if (dropwizardExtensionField == null) {
       LoggerFactory.getLogger(PolarisGrantRecord.class)
           .warn(
-              "Unable to find dropwizard extension field in test class "
-                  + extensionContext.getRequiredTestClass());
+              "Unable to find dropwizard extension field in test class {}",
+              extensionContext.getRequiredTestClass());
       return null;
     }
     DropwizardAppExtension appExtension =