debug testRequestBodyTooLarge

apache · Nov 25, 2024 · adfbbc2 · adfbbc2
1 parent 52529af
commit adfbbc2
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 11 deletions.
diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml
@@ -57,7 +57,7 @@ jobs:
           validate-wrappers: false
 
       - name: Check formatting
-        run: ./gradlew check
+        run: ./gradlew :polaris-service:test --tests org.apache.polaris.service.PolarisApplicationIntegrationTest
 
       - name: Check Maven publication
         run: ./gradlew publishToMavenLocal sourceTarball

diff --git a/polaris-service/build.gradle.kts b/polaris-service/build.gradle.kts
@@ -17,6 +17,7 @@
  * under the License.
  */
 
+import org.gradle.api.tasks.testing.logging.TestExceptionFormat
 import org.openapitools.generator.gradle.plugin.tasks.GenerateTask
 
 plugins {
@@ -229,6 +230,8 @@ tasks.named<Test>("test").configure {
   jvmArgs("--add-exports", "java.base/sun.nio.ch=ALL-UNNAMED")
   useJUnitPlatform()
   maxParallelForks = 4
+  testLogging.showStandardStreams = true
+  testLogging.exceptionFormat = TestExceptionFormat.FULL
 }
 
 /**

diff --git a/polaris-service/src/main/resources/application.properties b/polaris-service/src/main/resources/application.properties
@@ -110,6 +110,9 @@ polaris.storage.gcp.lifespan=PT1H
 %test.quarkus.log.category."org.apache.iceberg.rest.RESTSessionCatalog".level=ERROR
 %test.quarkus.log.category."org.apache.polaris.core.persistence.PolarisMetaStoreManagerImpl".level=ERROR
 %test.quarkus.log.category."org.apache.polaris.service.context.DefaultRealmContextResolver".level=ERROR
+%test.quarkus.log.category."org.apache.polaris.service.catalog.PolarisCatalogHandlerWrapper".level=ERROR
+%test.quarkus.log.category."org.apache.polaris.service.storage.PolarisStorageIntegrationProviderImpl".level=ERROR
+%test.quarkus.log.category."org.jboss.resteasy".level=DEBUG
 %test.quarkus.otel.enabled=false
 %test.quarkus.http.limits.max-body-size=1000000
 %test.polaris.context.default-realm=POLARIS

diff --git a/...s-service/src/test/java/org/apache/polaris/service/PolarisApplicationIntegrationTest.java b/...s-service/src/test/java/org/apache/polaris/service/PolarisApplicationIntegrationTest.java
@@ -685,7 +685,6 @@ public void testRequestBodyTooLarge() {
             .header("Authorization", "Bearer " + testHelper.adminToken)
             .header(REALM_PROPERTY_KEY, testHelper.realm)
             .post(largeRequest)) {
-      LOGGER.error("testRequestBodyTooLarge={}", response.getStatus());
       assertThat(response)
           .returns(Response.Status.REQUEST_ENTITY_TOO_LARGE.getStatusCode(), Response::getStatus);
     }

diff --git a/polaris-service/src/test/java/org/apache/polaris/service/catalog/TestUtil.java b/polaris-service/src/test/java/org/apache/polaris/service/catalog/TestUtil.java
@@ -50,7 +50,7 @@ public static RESTCatalog createSnowmanManagedCatalog(
       PolarisIntegrationTestHelper helper, Catalog catalog, Map<String, String> extraProperties) {
     return createSnowmanManagedCatalog(
         helper,
-        String.format("http://localhost:%d", helper.getLocalPort()),
+        String.format("http://localhost:%d", helper.localPort),
         helper.realm,
         catalog,
         extraProperties);

diff --git a/...s-service/src/test/java/org/apache/polaris/service/test/PolarisIntegrationTestHelper.java b/...s-service/src/test/java/org/apache/polaris/service/test/PolarisIntegrationTestHelper.java
@@ -56,12 +56,15 @@
 import org.apache.polaris.core.persistence.PolarisMetaStoreManager;
 import org.apache.polaris.core.persistence.PolarisMetaStoreSession;
 import org.apache.polaris.core.storage.aws.PolarisS3FileIOClientFactory;
+import org.apache.polaris.service.PolarisApplicationIntegrationTest;
 import org.apache.polaris.service.auth.TokenUtils;
 import org.apache.polaris.service.catalog.io.DefaultFileIOFactory;
 import org.apache.polaris.service.catalog.io.FileIOFactory;
 import org.apache.polaris.service.context.RealmContextResolver;
 import org.apache.polaris.service.persistence.InMemoryPolarisMetaStoreManagerFactory;
 import org.junit.jupiter.api.TestInfo;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 @Singleton
 public class PolarisIntegrationTestHelper {
@@ -112,14 +115,6 @@ public void setUp(TestInfo testInfo) {
             realm);
   }
 
-  public int getLocalPort() {
-    return localPort;
-  }
-
-  public int getLocalManagementPort() {
-    return localManagementPort;
-  }
-
   private void fetchAdminSecrets() {
     if (!(metaStoreManagerFactory instanceof InMemoryPolarisMetaStoreManagerFactory)) {
       metaStoreManagerFactory.bootstrapRealms(List.of(realm));
@@ -231,13 +226,17 @@ private void createSnowmanCredentials() {
     }
   }
 
+  private static final Logger LOGGER =
+      LoggerFactory.getLogger(PolarisIntegrationTestHelper.class);
+
   public void tearDown() {
     try {
       if (realm != null) {
         metaStoreManagerFactory.purgeRealms(List.of(realm));
       }
     } finally {
       if (client != null) {
+        LOGGER.warn("Closing client");
         client.close();
       }
     }