Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix license header in LongMsgOffset.java #6783

Merged
merged 1 commit into from
Apr 13, 2021
Merged

fix license header in LongMsgOffset.java #6783

merged 1 commit into from
Apr 13, 2021

Conversation

mqliang
Copy link
Contributor

@mqliang mqliang commented Apr 13, 2021

Description

license header in LongMsgOffset.java is placed in wrong place.

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@mqliang
Copy link
Contributor Author

mqliang commented Apr 13, 2021

@Jackie-Jiang The license header misplacing issue brings down tests for all on-going PR (don't know which PR checked in this wrong license header and why all tests passed for that PR, though). Can you take a look at this change and merge it fast?

Copy link
Contributor

@snleee snleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snleee snleee merged commit b9b31e5 into apache:master Apr 13, 2021
@mqliang mqliang deleted the header-fix branch April 13, 2021 06:25
@mqliang
Copy link
Contributor Author

mqliang commented Apr 13, 2021

@snleee Thanks for the quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants