-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test file for page index filter. #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- thank you @Ted-Jiang
data/README.md
Outdated
|null_list.parquet | an empty list. Generated from this json `{"emptylist":[]}` and for the purposes of testing correct read/write behaviour of this base case. | | ||
| null_list.parquet | an empty list. Generated from this json `{"emptylist":[]}` and for the purposes of testing correct read/write behaviour of this base case. | | ||
| alltypes_tiny_pages.parquet | small page sizes with dictionary encoding with page index | | ||
| alltypes_tiny_pages_plain.parquet | small page sizes without dictionary encoding with page index | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can also mention the file's lineage (that it came from impala, with link) in this comment
data/README.md
Outdated
|null_list.parquet | an empty list. Generated from this json `{"emptylist":[]}` and for the purposes of testing correct read/write behaviour of this base case. | | ||
| null_list.parquet | an empty list. Generated from this json `{"emptylist":[]}` and for the purposes of testing correct read/write behaviour of this base case. | | ||
| alltypes_tiny_pages.parquet | small page sizes with dictionary encoding with page index | | ||
| alltypes_tiny_pages_plain.parquet | small page sizes without dictionary encoding with page index | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| alltypes_tiny_pages_plain.parquet | small page sizes without dictionary encoding with page index | | |
| alltypes_tiny_pages_plain.parquet | small page sizes with plain encoding with page index | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alamb Thanks, fix all comment.
@wesm could please take a look. |
Related apache/arrow-rs#1977 (comment)
Add test file for page index, copy from impala https://github.com/apache/impala/blob/bb610dee09a8069bb993b4c668f7e481c1774b70/testdata/data/alltypes_tiny_pages.parquet