Embedded Kafka support in OpenWhisk Standalone mode #4628
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.openwhisk.standalone | ||
|
|
||
| import java.io.File | ||
|
|
||
| import akka.actor.ActorSystem | ||
| import akka.stream.ActorMaterializer | ||
| import kafka.server.KafkaConfig | ||
| import net.manub.embeddedkafka.{EmbeddedKafka, EmbeddedKafkaConfig} | ||
| import org.apache.commons.io.FileUtils | ||
| import org.apache.openwhisk.common.{Logging, TransactionId} | ||
| import org.apache.openwhisk.core.WhiskConfig | ||
| import org.apache.openwhisk.core.WhiskConfig.kafkaHosts | ||
| import org.apache.openwhisk.core.entity.ControllerInstanceId | ||
| import org.apache.openwhisk.core.loadBalancer.{LeanBalancer, LoadBalancer, LoadBalancerProvider} | ||
| import org.apache.openwhisk.standalone.StandaloneDockerSupport.{checkOrAllocatePort, containerName, createRunCmd} | ||
|
|
||
| import scala.concurrent.{ExecutionContext, Future} | ||
| import scala.reflect.io.Directory | ||
| import scala.util.Try | ||
|
|
||
| class KafkaLauncher(docker: StandaloneDockerClient, | ||
| kafkaPort: Int, | ||
| kafkaDockerPort: Int, | ||
| zkPort: Int, | ||
| workDir: File, | ||
| kafkaUi: Boolean)(implicit logging: Logging, | ||
| ec: ExecutionContext, | ||
| actorSystem: ActorSystem, | ||
| materializer: ActorMaterializer, | ||
| tid: TransactionId) { | ||
|
|
||
| def run(): Future[Seq[ServiceContainer]] = { | ||
| for { | ||
| kafkaSvcs <- runKafka() | ||
| uiSvcs <- if (kafkaUi) runKafkaUI() else Future.successful(Seq.empty[ServiceContainer]) | ||
| } yield kafkaSvcs ++ uiSvcs | ||
| } | ||
|
|
||
| def runKafka(): Future[Seq[ServiceContainer]] = { | ||
|
|
||
| //Below setting based on https://rmoff.net/2018/08/02/kafka-listeners-explained/ | ||
| // We configure two listeners where one is used for host based application and other is used for docker based application | ||
| // to connect to Kafka server running on host | ||
|
There was a problem hiding this comment. It would be helpful to add some more detail - for example, controller / invoker will use |
||
| val brokerProps = Map( | ||
| KafkaConfig.ListenersProp -> s"LISTENER_LOCAL://localhost:$kafkaPort,LISTENER_DOCKER://localhost:$kafkaDockerPort", | ||
| KafkaConfig.AdvertisedListenersProp -> s"LISTENER_LOCAL://localhost:$kafkaPort,LISTENER_DOCKER://${StandaloneDockerSupport | ||
| .getLocalHostIp()}:$kafkaDockerPort", | ||
| KafkaConfig.ListenerSecurityProtocolMapProp -> "LISTENER_LOCAL:PLAINTEXT,LISTENER_DOCKER:PLAINTEXT", | ||
| KafkaConfig.InterBrokerListenerNameProp -> "LISTENER_LOCAL") | ||
| implicit val config: EmbeddedKafkaConfig = | ||
| EmbeddedKafkaConfig(kafkaPort = kafkaPort, zooKeeperPort = zkPort, customBrokerProperties = brokerProps) | ||
|
|
||
| val t = Try { | ||
| EmbeddedKafka.startZooKeeper(createDir("zookeeper")) | ||
| EmbeddedKafka.startKafka(createDir("kafka")) | ||
| } | ||
|
|
||
| Future | ||
| .fromTry(t) | ||
| .map( | ||
| _ => | ||
| Seq( | ||
| ServiceContainer(kafkaPort, s"localhost:$kafkaPort", "kafka"), | ||
| ServiceContainer( | ||
| kafkaDockerPort, | ||
| s"${StandaloneDockerSupport.getLocalHostIp()}:$kafkaDockerPort", | ||
| "kafka-docker"), | ||
| ServiceContainer(zkPort, "Zookeeper", "zookeeper"))) | ||
| } | ||
|
|
||
| def runKafkaUI(): Future[Seq[ServiceContainer]] = { | ||
| val hostIp = StandaloneDockerSupport.getLocalHostIp() | ||
| val port = checkOrAllocatePort(9000) | ||
| val env = Map( | ||
| "ZOOKEEPER_CONNECT" -> s"$hostIp:$zkPort", | ||
| "KAFKA_BROKERCONNECT" -> s"$hostIp:$kafkaDockerPort", | ||
| "JVM_OPTS" -> "-Xms32M -Xmx64M", | ||
| "SERVER_SERVLET_CONTEXTPATH" -> "/") | ||
|
|
||
| logging.info(this, s"Starting Kafka Drop UI port: $port") | ||
| val name = containerName("kafka-drop-ui") | ||
| val params = Map("-p" -> Set(s"$port:9000")) | ||
| val args = createRunCmd(name, env, params) | ||
|
|
||
| val f = docker.runDetached("obsidiandynamics/kafdrop", args, true) | ||
| f.map(_ => Seq(ServiceContainer(port, s"http://localhost:$port", name))) | ||
| } | ||
|
|
||
| private def createDir(name: String) = { | ||
| val dir = new File(workDir, name) | ||
| FileUtils.forceMkdir(dir) | ||
| Directory(dir) | ||
| } | ||
|
There was a problem hiding this comment. Is embedded Kafka writing topic message logs to this work directory? If yes, do we clean up this data when shutting the standalone openwhisk down? If not, there is a chance that this directory grows large depending on Kafka retention policy and number of activations... If this data is only cleaned up on system reboot, the directory can grow large over time. There was a problem hiding this comment. Currently the dir would be cleaned upon standalone jar restart (not system restart). For now not deleting the files upon exit |
||
| } | ||
|
|
||
| object KafkaAwareLeanBalancer extends LoadBalancerProvider { | ||
| override def requiredProperties: Map[String, String] = LeanBalancer.requiredProperties ++ kafkaHosts | ||
|
|
||
| override def instance(whiskConfig: WhiskConfig, instance: ControllerInstanceId)( | ||
| implicit actorSystem: ActorSystem, | ||
| logging: Logging, | ||
| materializer: ActorMaterializer): LoadBalancer = LeanBalancer.instance(whiskConfig, instance) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.openwhisk.standalone | ||
|
|
||
| import common.WskProps | ||
| import org.junit.runner.RunWith | ||
| import org.scalatest.junit.JUnitRunner | ||
| import system.basic.WskRestBasicTests | ||
|
|
||
| @RunWith(classOf[JUnitRunner]) | ||
| class StandaloneKafkaTests extends WskRestBasicTests with StandaloneServerFixture with StandaloneSanityTestSupport { | ||
| override implicit val wskprops = WskProps().copy(apihost = serverUrl) | ||
|
|
||
| override protected def supportedTests = Set("Wsk Action REST should invoke a blocking action and get only the result") | ||
|
|
||
| override protected def extraArgs: Seq[String] = Seq("--kafka") | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Kafdrop 3][6]-> is this supposed to link to two different places, "3" and "6"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No thats the actual name Kafdrop 3