expose and run GC for nodejs to avoid memory intensive actions to run…

… in memory limit

run garbage collector automatically

core/nodejs6Action/Dockerfile

@@ -75,4 +75,4 @@ xmlhttprequest@1.8.0 \
 yauzl@2.7.0
 
 # See app.js
-CMD node app.js
+CMD node --expose-gc app.js

core/nodejsAction/Dockerfile

@@ -53,4 +53,4 @@ xmlhttprequest@1.7.0 \
 yauzl@2.3.1
 
 # See app.js
-CMD node app.js
+CMD node --expose-gc app.js

core/nodejsActionBase/src/service.js

@@ -107,9 +107,16 @@ function NodeActionService(config, logger) {
         if (status === Status.ready) {
             setStatus(Status.running);
 
-            return doRun(req).then(function (result) {
-                setStatus(Status.ready);
+            var userCodePromise = doRun(req);
+            var garbageCollectorPromise = new Promise(function (resolve, reject) {
+                    global.gc();
+                    resolve();
+                }
+            );
 
+            return Promise.all([userCodePromise, garbageCollectorPromise]).then(function (resolvedPromises) {
+                var result = resolvedPromises[0];
+                setStatus(Status.ready);
                 if (typeof result !== "object") {
                     console.error('Result must be of type object but has type "' + typeof result + '":', result);
                     return errorMessage(502, "The action did not return a dictionary.");

tests/dat/actions/memory.js

@@ -0,0 +1,12 @@
+function eat(memoryMB) {
+  var bytes = 1*1024*1024*memoryMB;
+  var buffer = new Buffer.alloc(bytes, 'a');
+  buffer = null;
+  console.log('done.');
+}
+
+function main(msg) {
+    console.log('helloEatMemory', 'memory ' + msg.payload + 'MB');
+    eat(msg.payload);
+    return {msg: 'OK, buffer of size ' + msg.payload + ' MB has been filled.'};
+}

tests/src/test/scala/whisk/core/limits/ActionLimitsTests.scala

@@ -234,4 +234,24 @@ class ActionLimitsTests extends TestHelpers with WskTestHelpers {
                     }.length shouldBe 1
             }
     }
+
+    it should "be able to run memory intensive actions multiple times by running the GC in the action" in withAssetCleaner(wskprops) {
+        (wp, assetHelper) =>
+            val name = "TestNodeJsMemoryActionAbleToRunOften"
+            assetHelper.withCleaner(wsk.action, name, confirmDelete = true) {
+                val allowedMemory = 512 megabytes
+                val actionName = TestUtils.getTestActionFilename("memory.js")
+                (action, _) => action.create(name, Some(actionName), memory = Some(allowedMemory))
+            }
+
+            for( a <- 1 to 10){
+                val run = wsk.action.invoke(name, Map("payload" -> "128".toJson))
+                withActivation(wsk.activation, run) { response =>
+                    response.response.status shouldBe "success"
+                    response.response.result shouldBe Some(JsObject(
+                        "msg" -> "OK, buffer of size 128 MB has been filled.".toJson))
+                }
+            }
+    }
+
 }