Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow digits in the configuration key names #29

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

dcremonini
Copy link
Contributor

@dcremonini dcremonini commented Sep 30, 2024

This allows digits in a non leading position.
For example, the names HELLO3 and HELLO_A_B_C3 are now allowed.
Closes apache/openserverless#69

@dcremonini dcremonini requested a review from giusdp September 30, 2024 20:19
@dcremonini dcremonini marked this pull request as ready for review September 30, 2024 20:19
@dcremonini
Copy link
Contributor Author

@giusdp I committed the transpiled version too, not sure it's useful though. Please let me know if it's needed or not, so I can possibly remove it before merging.

@giusdp
Copy link
Member

giusdp commented Sep 30, 2024

lgtm

@giusdp giusdp merged commit 7c3b347 into main Sep 30, 2024
@dcremonini dcremonini deleted the feat/allow_digits_in_configuration_key_names branch November 2, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task-util-config: allow digits in the name of the configuration keys
2 participants