Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(!): Supabase is now an S3-compatible servcices #5663

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Feb 26, 2025

Which issue does this PR close?

Supabase is now an S3-compatible service: https://github.com/supabase/storage

This change also allows us to eliminate some workarounds for failed tests in Supabase.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 26, 2025

Thank you @messense for the review.

@Xuanwo Xuanwo merged commit 0e41a17 into main Feb 26, 2025
280 checks passed
@Xuanwo Xuanwo deleted the remove-supabase branch February 26, 2025 07:26
@tisonkun
Copy link
Member

tisonkun commented Feb 26, 2025

We should need an upgrade note for this somehow breaking/notable change.

@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 26, 2025

We should need an upgrade note for this somehow breaking/notable change.

Yes!

@Xuanwo Xuanwo changed the title refactor: Supabase is now an S3-compatible servcices refactor(1): Supabase is now an S3-compatible servcices Feb 26, 2025
@Xuanwo Xuanwo changed the title refactor(1): Supabase is now an S3-compatible servcices refactor(!): Supabase is now an S3-compatible servcices Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants