Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(core): add tests for versioning #5132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(core): add tests for versioning #5132

wants to merge 1 commit into from

Conversation

meteorgan
Copy link
Contributor

@meteorgan meteorgan commented Sep 21, 2024 •
edited
Loading

Which issue does this PR close?

part of: #2611

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@meteorgan meteorgan marked this pull request as ready for review September 21, 2024 11:32
@meteorgan
Copy link
Contributor Author

In #5106, I didn't address the DeleteMarker in the response. However, it could be useful for the users who want to know which objects haven been deleted. Should we return the DeleteMarker as a object version with a delete_marker tag when performing a list_with_version request ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Awaiting requested review from Xuanwo Xuanwo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@meteorgan