feat:add if_none_match for write #5129
Open
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LeeHao <HaozzaLi@gmail.com>
Xuanwo
reviewed
Sep 20, 2024
| /// | ||
| /// This feature can be used to check if the file already exists. | ||
| /// This prevents overwriting of existing objects with identical key names. | ||
| /// And must use the * (asterisk) value with this parameter |
There was a problem hiding this comment.
S3 only supports *, but other services may support different options. We can revise the statement to say users can use * to verify if a file already exists by matching with any ETag.
| /// use opendal::Operator; | ||
| /// # async fn test(op: Operator, etag: &str) -> Result<()> { | ||
| /// let bs = b"hello, world!".to_vec(); | ||
| /// let mut metadata = op.write_with("path/to/file", bs).if_none_match("*").await?; |
There was a problem hiding this comment.
write didn't return metadata for now.
| /// This prevents overwriting of existing objects with identical key names. | ||
| /// And must use the * (asterisk) value with this parameter | ||
| /// | ||
| /// If file exists, an error with kind [`ErrorKind::ConditionNotMatch`] will be returned. |
There was a problem hiding this comment.
Perhaps we can also provide an example to demonstrate how to handle this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5097
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
Yes, add an option
if_none_matchforwrite_with.