Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Nodejs add devbox #4791

Merged
merged 3 commits into from
Jun 23, 2024
Merged

feat: Nodejs add devbox #4791

merged 3 commits into from
Jun 23, 2024

Conversation

bxb100
Copy link
Contributor

@bxb100 bxb100 commented Jun 23, 2024

devbox is a nix wrapper, but simpler to use

@github-actions github-actions bot requested review from G-XD and silver-ymz June 23, 2024 12:44
@bxb100 bxb100 changed the title Nodejs add devbox feat: Nodejs add devbox Jun 23, 2024
@bxb100 bxb100 marked this pull request as ready for review June 23, 2024 13:12
@bxb100 bxb100 requested a review from suyanhanx as a code owner June 23, 2024 13:12
@suyanhanx
Copy link
Member

Thank you for your contribution! But I think these things should be left up to the user to decide.

@bxb100
Copy link
Contributor Author

bxb100 commented Jun 23, 2024

Thank you for your contribution! But I think these things should be left up to the user to decide.

ye, but if you don't run devbox shell these configs don't affect your environment

Xuanwo
Xuanwo approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm eager to make Node.js developers happy.

All those setups will become outdated and eventually unusable if no one maintian them. We can simply remove them when that happens.

@Xuanwo Xuanwo merged commit b3517ff into apache:main Jun 23, 2024
57 checks passed
@Xuanwo Xuanwo mentioned this pull request Jun 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@G-XD G-XD Awaiting requested review from G-XD

@silver-ymz silver-ymz Awaiting requested review from silver-ymz

@suyanhanx suyanhanx Awaiting requested review from suyanhanx suyanhanx is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bxb100 @suyanhanx @Xuanwo