feat: setup cloud filter integration #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Jun 21, 2024
integrations/README.md
Outdated
| - [`unftp-sbe-opendal`](unftp-sbe/README.md): Use OpenDAL as a backend to access data in various services with FTP protocol. | ||
|
|
||
| - [`cloudfilter_opendal`](cloudfilter/README.md): Use OpenDAL as a backend to access data in various services with CloudFilter. |
There was a problem hiding this comment.
Would you like to provide a link to cloudfilter and provide some description about this crate?
integrations/cloudfilter/Cargo.lock
Outdated
There was a problem hiding this comment.
Please don't include Cargo.lock for integrations.
integrations/cloudfilter/Cargo.toml
Outdated
|
|
||
| [package] | ||
| authors = ["Apache OpenDAL <dev@opendal.apache.org>"] | ||
| description = "unftp Integration for Apache OpenDAL" |
|
|
||
| use opendal::Operator; | ||
|
|
||
| pub trait SyncFilter {} |
There was a problem hiding this comment.
This trait doesn't make sense. I prefer to leave an emptry lib.rs with hello world instead.
|
Hello @Xuanwo, PTAL :) |
Xuanwo
approved these changes
Jun 26, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.