Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add test case for hdfs over gcs bucket #4145

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

ArmandoZ
Copy link
Contributor

@ArmandoZ ArmandoZ commented Feb 5, 2024

Issue: #3504

Adds test case for hdfs over gcs bucket. Tested locally with my own gcs bucket.

TODO: Need to change how we obtain secret information from the test case (please see comments in code)

.github/workflows/service_test_hdfs.yml Outdated Show resolved Hide resolved
fixtures/hdfs/core-site.xml Outdated Show resolved Hide resolved
.github/workflows/service_test_hdfs.yml Outdated Show resolved Hide resolved
.github/workflows/service_test_hdfs.yml Outdated Show resolved Hide resolved
fixtures/hdfs/core-site.xml Outdated Show resolved Hide resolved
fixtures/hdfs/core-site.xml Outdated Show resolved Hide resolved
@ArmandoZ ArmandoZ force-pushed the add_hdfs_gcs branch 2 times, most recently from c9491a9 to 9c1e273 Compare February 5, 2024 03:52
@Xuanwo Xuanwo changed the title ci: Add test case for hdfs over gcs bucket (#3504) ci: Add test case for hdfs over gcs bucket Feb 5, 2024
@ArmandoZ ArmandoZ force-pushed the add_hdfs_gcs branch 2 times, most recently from 4240700 to 7911458 Compare February 6, 2024 06:45
@ArmandoZ ArmandoZ marked this pull request as ready for review February 6, 2024 07:05
@ArmandoZ ArmandoZ requested a review from PsiACE as a code owner February 6, 2024 07:05
@Xuanwo
Copy link
Member

Xuanwo commented Feb 7, 2024

Workflow: https://github.com/apache/opendal/actions/runs/7811201570/job/21305944190?pr=4167

2024-02-07 07:15:21,938 ERROR conf.Configuration: error parsing conf core-site.xml
com.ctc.wstx.exc.WstxParsingException: Illegal processing instruction target ("xml"); xml (case insensitive) is reserved by the specs.
 at [row,col,system-id]: [21,5,"file:/home/runner/hadoop-3.3.5/etc/hadoop/core-site.xml"]
	at com.ctc.wstx.sr.StreamScanner.constructWfcException(StreamScanner.java:634)
	at com.ctc.wstx.sr.StreamScanner.throwParseError(StreamScanner.java:504)
	at com.ctc.wstx.sr.BasicStreamReader.readPIPrimary(BasicStreamReader.java:4004)
	at com.ctc.wstx.sr.BasicStreamReader.nextFromProlog(BasicStreamReader.java:2138)
	at com.ctc.wstx.sr.BasicStreamReader.next(BasicStreamReader.java:1179)
	at org.apache.hadoop.conf.Configuration$Parser.parseNext(Configuration.java:3405)
	at org.apache.hadoop.conf.Configuration$Parser.parse(Configuration.java:3191)
	at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:3084)
	at org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:3045)
	at org.apache.hadoop.conf.Configuration.loadProps(Configuration.java:2923)
	at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2905)
	at org.apache.hadoop.conf.Configuration.get(Configuration.java:1247)
	at org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1301)
	at org.apache.hadoop.conf.Configuration.getInt(Configuration.java:1527)
	at org.apache.hadoop.fs.FileSystem$Cache.<init>(FileSystem.java:3615)
	at org.apache.hadoop.fs.FileSystem.<clinit>(FileSystem.java:206)
could not find method getRootCauseMessage from class (null) with signature (Ljava/lang/Throwable;)Ljava/lang/String;
could not find method getStackTrace from class (null) with signature (Ljava/lang/Throwable;)Ljava/lang/String;

@ArmandoZ
Copy link
Contributor Author

ArmandoZ commented Feb 7, 2024

Workflow: https://github.com/apache/opendal/actions/runs/7811201570/job/21305944190?pr=4167

Got it. I'm looking into that. Will let you know when ready to run again.

@Xuanwo
Copy link
Member

Xuanwo commented Feb 7, 2024

Test failed for:

hdfsBuilderConnect(forceNewInstance=0, nn=gs://***, port=0, kerbTicketCachePath=(NULL), userName=(NULL)) error:
UnsupportedFileSystemException: No FileSystem for scheme "gs"org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme "gs"
	at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:3546)
	at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:3569)
	at org.apache.hadoop.fs.FileSystem.access$300(FileSystem.java:174)
	at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:3673)
	at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:3624)
	at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:557)
	at org.apache.hadoop.fs.FileSystem$1.run(FileSystem.java:278)
	at org.apache.hadoop.fs.FileSystem$1.run(FileSystem.java:275)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/javax.security.auth.Subject.doAs(Subject.java:423)
	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899)
	at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:275)

@ArmandoZ
Copy link
Contributor Author

ArmandoZ commented Feb 7, 2024

Test failed for:

Direct reason is hadoop didn't read the gcs-connector jar library. Probably need to set HADOOP_CLASSPATH under ci environment to read that. Updated.

@Xuanwo
Copy link
Member

Xuanwo commented Feb 7, 2024

Test passed! Thanks a lot for your work!

image

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit a64e9a5 into apache:main Feb 7, 2024
430 checks passed
@ArmandoZ
Copy link
Contributor Author

ArmandoZ commented Feb 7, 2024

Sounds great! Thanks for the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants