Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix format after adding editorconfig #1990

Merged
merged 4 commits into from
Apr 14, 2023
Merged

ci: Fix format after adding editorconfig #1990

merged 4 commits into from
Apr 14, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 14, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
@suyanhanx
Copy link
Member

This is not quite in line with common JS practice. Let me reconsider.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 14, 2023

This is not quite in line with common JS practice. Let me reconsider.

Feel free to push directly on this PR🤩

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
bindings/nodejs/README.md Outdated Show resolved Hide resolved
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo Xuanwo merged commit 16ad3c7 into main Apr 14, 2023
@Xuanwo Xuanwo deleted the fix-format branch April 14, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants