Documented: Simple production setup+quick refinements #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For image files isValidFile should not checkMaxLinesLength, since that was created to check text files. Image validation is done by isValidImageFile Thanks: Ingo Wolfmayr and Jacques Le Roux for the work so far in (OFBIZ-12639)
|
|
Hi @grozadanut, I tried to apply your patch and got this After removing the unecessary parts I got no problem. |
|
Thanks ! |
|
Might be because my trunk fork appears to be 14 commits ahead of the source repository. I think it's some kind of git issue. I might need to rebase my repo on the official trunk version or something... I'll try some git commands when I get the chance. |
|
Yes, not a big deal this time, sometimes it's more difficult. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented: Simple production setup+quick refinements