-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved: Add permission check for view-maps and change defaults for request-maps (OFBIZ-13130) #831
Merged
JacquesLeRoux
merged 8 commits into
apache:trunk
from
ecomify:OFBIZ-13130_Add_permission_check_for_view-maps_and_change_defaults_for_request_maps_in_framework
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
request-maps [(OFBIZ-13130)] Adds an auth parameter to view-maps. The parameter is used in renderView and initializes a security check.
request-maps [(OFBIZ-13130)] Changes the defaults of the request-map parameters auth and https to true.
request-maps [(OFBIZ-13130)] Adds missing request- and view-map parameters in framework to restore the original functionality.
request-maps [(OFBIZ-13130)] Adds missing view-map parameter in applications/accounting to restore the original functionality.
request-maps [(OFBIZ-13130)] Adds missing request-map parameter in applications/content to restore the original functionality.
request-maps [(OFBIZ-13130)] Adds missing request- and view-map parameters in framework to restore the original functionality.
request-maps [(OFBIZ-13130)] Adds missing request- and view-map parameters in applications/product to restore the original functionality.
request-maps [(OFBIZ-13130)] Adds missing request-map parameter in applications/workeffort to restore the original functionality.
Quality Gate passedIssues Measures |
asfgit
pushed a commit
that referenced
this pull request
Aug 24, 2024
…request-maps (OFBIZ-13130) (#831) * [Improved]: Add permission check for view-maps and change defaults for request-maps [(OFBIZ-13130)] Adds an auth parameter to view-maps. The parameter is used in renderView and initializes a security check. * [Improved]: Add permission check for view-maps and change defaults for request-maps [(OFBIZ-13130)] Changes the defaults of the request-map parameters auth and https to true. * [Improved]: Add permission check for view-maps and change defaults for request-maps [(OFBIZ-13130)] Adds missing request- and view-map parameters in framework to restore the original functionality. * [Improved]: Add permission check for view-maps and change defaults for request-maps [(OFBIZ-13130)] Adds missing view-map parameter in applications/accounting to restore the original functionality. * [Improved]: Add permission check for view-maps and change defaults for request-maps [(OFBIZ-13130)] Adds missing request-map parameter in applications/content to restore the original functionality. * [Improved]: Add permission check for view-maps and change defaults for request-maps [(OFBIZ-13130)] Adds missing request- and view-map parameters in framework to restore the original functionality. * [Improved]: Add permission check for view-maps and change defaults for request-maps [(OFBIZ-13130)] Adds missing request- and view-map parameters in applications/product to restore the original functionality. * [Improved]: Add permission check for view-maps and change defaults for request-maps [(OFBIZ-13130)] Adds missing request-map parameter in applications/workeffort to restore the original functionality. Conflicts handled by hand (hopefully all correct, ain't easy) applications/order/webapp/ordermgr/WEB-INF/controller.xml framework/common/webcommon/WEB-INF/common-controller.xml framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ConfigXMLReader.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved: Add permission check for view-maps and change defaults for request-maps (OFBIZ-13130)
Implemented an additional view-map parameter "auth" with a security check in RequestHandler.renderView. The default is set to "true".
The defaults for the request-map parameters "https" and "auth" were also changed to "true".
Alle request-maps and view-maps in framework, applications and plugins were checked and missing parameters were added to recreate to original functionality.