Fixed: PaymentGroup Cancell button is shown to viewer (OFBIZ-12820) #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when a user with only view permissions accesses the PaymentGroup overview, as demonstrated in demo-trunk with userid=auditor, the action trigger to cancel a PaymentGroup is shown. See attached image. modified: PaymentGroupForms.xml - removed action trigger field regarding cancelCheckRunPayments
|
|
It looks like the action is simple removed for everyone instead of checking the permission? |
|
The trigger to cancel a PaymentGroup is still available on the page of the PaymentGroup. See https://demo-trunk.ofbiz.apache.org/accounting/control/PaymentGroupOverview?paymentGroupId=9000. IMO, cancelling a PaymentGroup in an overview with less detail than available in the page of the PaymentGroup should be discouraged as accidental cancellations do happen. |
asfgit
pushed a commit
that referenced
this pull request
Mar 9, 2024
…698) Currently when a user with only view permissions accesses the PaymentGroup overview, as demonstrated in demo-trunk with userid=auditor, the action trigger to cancel a PaymentGroup is shown. See attached image. modified: PaymentGroupForms.xml - removed action trigger field regarding cancelCheckRunPayments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a user with only view permissions accesses the PaymentGroup overview, as demonstrated in demo-trunk with userid=auditor, the action trigger to cancel a PaymentGroup is shown. See attached image.
modified: PaymentGroupForms.xml