Improved: Make sure no pdf files containing unwanted attachments can …

…be uploaded (OFBIZ-12926) Fixes checkstyle issues
apache · Mar 12, 2024 · 3d755e7 · 3d755e7
1 parent c3653d5
commit 3d755e7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java b/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java
@@ -527,7 +527,7 @@ private static boolean isValidPdfFile(String fileName) {
                     } else {
                         try {
                             Document document = UtilXml.readXmlDocument(importer.getUTF8());
-                            if (document.toString().equals("[#document: null]"))  {
+                            if (document.toString().equals("[#document: null]")) {
                                 safeState = false;
                                 Debug.logInfo("The file " + file.getAbsolutePath()
                                         + " is not a readable (valid and secure) PDF file. For security reason it's not accepted as a such file",
@@ -546,7 +546,8 @@ private static boolean isValidPdfFile(String fileName) {
             safeState = Objects.isNull(efTree) || canParseZUGFeRD;
         } catch (Exception e) {
             safeState = false;
-            Debug.logInfo(e, "The file " + file.getAbsolutePath() + " is not a readable (valid and secure) PDF file. For security reason it's not accepted as a such file",
+            Debug.logInfo(e, "The file " + file.getAbsolutePath() + " is not a readable (valid and secure) PDF file. "
+                    + "For security reason it's not accepted as a such file",
                     MODULE);
         }
         file = new File(fileName);