Fixed: Outdated method call in ShoppingListServicesScript.groovy (#726)

(OFBIZ-12939)
apache · Mar 14, 2024 · 1d09747 · 1d09747
1 parent 4412dc1
commit 1d09747
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/...der/src/main/groovy/org/apache/ofbiz/order/shoppinglist/ShoppingListServicesScript.groovy b/...der/src/main/groovy/org/apache/ofbiz/order/shoppinglist/ShoppingListServicesScript.groovy
@@ -71,7 +71,6 @@ Map updateShoppingList() {
 
 /**
  * Create a ShoppingList Item
- * @return
  */
 Map createShoppingListItem() {
     Map result = success()
@@ -87,16 +86,15 @@ Map createShoppingListItem() {
                     .where('shoppingListId', parameters.shoppingListId, 'shoppingListItemSeqId', shoppingListItem.shoppingListItemSeqId)
                     .queryList()
             if ((!slItemAttributes && !parameters.shoppingListItemAttributes) ||
-                UtilValidate.areEqual(slItemAttributes, parameters.shoppingListItemAttributes)) {
-                    BigDecimal totalquantity = shoppingListItem.quantity + parameters.quantity
-                    result.shoppingListItemSeqId = shoppingListItem.shoppingListItemSeqId
-                    Map serviceResult = run service: 'updateShoppingListItem', with: [*       : shoppingListItem,
-                        quantity: totalquantity]
-                    if (!ServiceUtil.isSuccess(serviceResult)) {
-                        return error(serviceResult.errorMessage)
-                    }
-                    // Exit here, because we found an existing item update, otherwise we have to create a new one below
-                    return result
+                    Objects.equals(slItemAttributes, parameters.shoppingListItemAttributes)) {
+                BigDecimal totalquantity = shoppingListItem.quantity + parameters.quantity
+                result.shoppingListItemSeqId = shoppingListItem.shoppingListItemSeqId
+                Map serviceResult = run service: 'updateShoppingListItem', with: [*: shoppingListItem, quantity: totalquantity]
+                if (!ServiceUtil.isSuccess(serviceResult)) {
+                    return error(serviceResult.errorMessage)
+                }
+                // Exit here, because we found an existing item update, otherwise we have to create a new one below
+                return result
             }
         }
     }