Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nxstyle] fix Relative file path #3005

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

simbit18
Copy link
Contributor

Summary

fix Relative file path does not match actual file.

Impact

Impact on user: NO

Impact on build: NO

Impact on hardware: NO

Impact on documentation: NO

Impact on security: NO

Impact on compatibility: NO

Testing

local

fix Relative file path does not match actual file.

Signed-off-by: simbit18 <simbit18@gmail.com>
Copy link
Member

@lupyuen lupyuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again :-)

@nuttxpr
Copy link

nuttxpr commented Feb 21, 2025

[Experimental Bot, please feedback here]

No. The PR description lacks crucial information required by the NuttX guidelines. While it addresses some sections, it's far too brief and doesn't provide the necessary details.

Here's what's missing:

  • Summary: Needs a more detailed explanation. "Relative file path does not match actual file" is a symptom, not a description of the why, what, and how. What file path is incorrect? Where is it used? How was it fixed? What part of the code was changed? Any related NuttX issues?
  • Testing: "local" is insufficient. Provide specifics about the build host (OS, CPU architecture, compiler version) and the target platform (architecture, board, configuration). Include actual testing logs before and after the change to demonstrate the fix. Just stating that it works isn't enough.

Without these details, it's impossible to determine if the PR truly meets the requirements. The current description makes it difficult to review and understand the changes.

@hartmannathan hartmannathan merged commit 4315a1c into apache:master Feb 21, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants