Remove unused header files across multiple source files

Clean up code by removing redundant and unused header file includes that were identified through static analysis. This improves code readability and reduces unnecessary dependencies. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
apache · Jan 10, 2025 · ffd256d · ffd256d
1 parent a5a93c0
commit ffd256d
Show file tree

Hide file tree

Showing 44 changed files with 0 additions and 66 deletions.
diff --git a/canutils/slcan/slcan.c b/canutils/slcan/slcan.c
@@ -46,7 +46,6 @@
 #include <sys/socket.h>
 #include <syslog.h>
 #include <sys/uio.h>
-#include <net/if.h>
 #include <termios.h>
 #include <nuttx/can.h>
 

diff --git a/examples/can/can_main.c b/examples/can/can_main.c
@@ -36,7 +36,6 @@
 #include <fcntl.h>
 #include <errno.h>
 #include <debug.h>
-#include <unistd.h>
 
 #include <nuttx/can/can.h>
 

diff --git a/examples/module/main/module_main.c b/examples/module/main/module_main.c
@@ -36,7 +36,6 @@
 #include <string.h>
 #include <unistd.h>
 #include <fcntl.h>
-#include <string.h>
 #include <syslog.h>
 #include <errno.h>
 #include <debug.h>

diff --git a/examples/nimble/nimble_main.c b/examples/nimble/nimble_main.c
@@ -34,8 +34,6 @@
 #include <unistd.h>
 #include <sys/boardctl.h>
 #include <assert.h>
-#include <stdbool.h>
-#include <stdint.h>
 
 #include "netutils/netinit.h"
 
@@ -51,7 +49,6 @@
 #include "services/ias/ble_svc_ias.h"
 #include "services/lls/ble_svc_lls.h"
 #include "services/tps/ble_svc_tps.h"
-#include "services/gap/ble_svc_gap.h"
 #include "services/bas/ble_svc_bas.h"
 #include "services/dis/ble_svc_dis.h"
 

diff --git a/examples/nrf24l01_btle/nrf24l01_btle.c b/examples/nrf24l01_btle/nrf24l01_btle.c
@@ -38,7 +38,6 @@
 #include <stdio.h>
 #include <poll.h>
 #include <fcntl.h>
-#include <unistd.h>
 
 #include "nrf24l01_btle.h"
 

diff --git a/examples/relays/relays_main.c b/examples/relays/relays_main.c
@@ -36,8 +36,6 @@
 #include <errno.h>
 #include <debug.h>
 
-#include <nuttx/arch.h>
-
 #ifdef CONFIG_ARCH_RELAYS
 
 /****************************************************************************

diff --git a/examples/rpmsgsocket/rpsock_server.c b/examples/rpmsgsocket/rpsock_server.c
@@ -34,7 +34,6 @@
 #include <stdbool.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <stdbool.h>
 #include <string.h>
 #include <unistd.h>
 #include <sys/socket.h>

diff --git a/examples/usbserial/host.c b/examples/usbserial/host.c
@@ -24,8 +24,6 @@
  * Included Files
  ****************************************************************************/
 
-#include <stdio.h>
-
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <stdio.h>

diff --git a/examples/usrsocktest/usrsocktest_noblock_connect.c b/examples/usrsocktest/usrsocktest_noblock_connect.c
@@ -33,7 +33,6 @@
 #include <unistd.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>
-#include <unistd.h>
 
 #include "defines.h"
 

diff --git a/netutils/pppd/pppd.c b/netutils/pppd/pppd.c
@@ -50,7 +50,6 @@
 #include <fcntl.h>
 #include <errno.h>
 #include <poll.h>
-#include <time.h>
 #include <debug.h>
 #include <unistd.h>
 

diff --git a/netutils/telnetc/telnetc.c b/netutils/telnetc/telnetc.c
@@ -47,7 +47,6 @@
 #include <string.h>
 #include <stdio.h>
 #include <errno.h>
-#include <string.h>
 #include <stdarg.h>
 
 #if defined(HAVE_ZLIB)

diff --git a/netutils/thttpd/fdwatch.c b/netutils/thttpd/fdwatch.c
@@ -41,7 +41,6 @@
 #include <sys/param.h>
 #include <debug.h>
 #include <poll.h>
-#include <debug.h>
 
 #include "config.h"
 #include "thttpd_alloc.h"

diff --git a/system/vi/vi.c b/system/vi/vi.c
@@ -35,7 +35,6 @@
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdio.h>
-#include <stdarg.h>
 #include <string.h>
 #include <ctype.h>
 #include <syslog.h>

diff --git a/system/zmodem/zm_state.c b/system/zmodem/zm_state.c
@@ -44,7 +44,6 @@
 #include <unistd.h>
 #include <string.h>
 #include <ctype.h>
-#include <ctype.h>
 #include <fcntl.h>
 #include <sched.h>
 #include <assert.h>

diff --git a/testing/drivertest/drivertest_framebuffer.c b/testing/drivertest/drivertest_framebuffer.c
@@ -31,7 +31,6 @@
 #include <sys/ioctl.h>
 #include <sys/mman.h>
 #include <sys/stat.h>
-#include <sys/types.h>
 #include <sys/param.h>
 
 #include <stdio.h>

diff --git a/testing/drivertest/drivertest_i2c_spi.c b/testing/drivertest/drivertest_i2c_spi.c
@@ -31,7 +31,6 @@
 #include <stdio.h>
 #include <stdarg.h>
 #include <stddef.h>
-#include <stdio.h>
 #include <stdint.h>
 #include <stdlib.h>
 #include <string.h>

diff --git a/testing/drivertest/drivertest_lcd.c b/testing/drivertest/drivertest_lcd.c
@@ -33,7 +33,6 @@
 #include <sys/ioctl.h>
 #include <sys/mman.h>
 #include <sys/stat.h>
-#include <sys/types.h>
 #include <sys/param.h>
 
 #include <stdio.h>

diff --git a/testing/drivertest/drivertest_watchdog.c b/testing/drivertest/drivertest_watchdog.c
@@ -34,7 +34,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
-#include <fcntl.h>
 #include <errno.h>
 #include <debug.h>
 #include <inttypes.h>

diff --git a/testing/ostest/schedlock.c b/testing/ostest/schedlock.c
@@ -44,7 +44,6 @@
 #include <pthread.h>
 #include <errno.h>
 #include <sched.h>
-#include <unistd.h>
 #include <stdint.h>
 
 #ifdef CONFIG_SIM_WALLTIME_SLEEP

diff --git a/testing/testsuites/kernel/fs/cases/fs_append_test.c b/testing/testsuites/kernel/fs/cases/fs_append_test.c
@@ -30,7 +30,6 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <string.h>
-#include <fcntl.h>
 #include <syslog.h>
 #include <stdint.h>
 #include <stdarg.h>

diff --git a/testing/testsuites/kernel/fs/cases/fs_creat_test.c b/testing/testsuites/kernel/fs/cases/fs_creat_test.c
@@ -30,7 +30,6 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <string.h>
-#include <fcntl.h>
 #include <syslog.h>
 #include <stdint.h>
 #include <stdarg.h>

diff --git a/testing/testsuites/kernel/fs/cases/fs_pread_test.c b/testing/testsuites/kernel/fs/cases/fs_pread_test.c
@@ -25,19 +25,16 @@
  ****************************************************************************/
 #include <nuttx/config.h>
 #include <errno.h>
-#include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdarg.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <string.h>
 #include <stdint.h>
-#include <stdarg.h>
 #include <stddef.h>
 #include <setjmp.h>
 #include <cmocka.h>
-#include <stdio.h>
 #include "fstest.h"
 
 /****************************************************************************

diff --git a/testing/testsuites/kernel/fs/cases/fs_pwrite_test.c b/testing/testsuites/kernel/fs/cases/fs_pwrite_test.c
@@ -25,15 +25,13 @@
  ****************************************************************************/
 #include <nuttx/config.h>
 #include <errno.h>
-#include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdarg.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <string.h>
 #include <stdint.h>
-#include <stdarg.h>
 #include <stddef.h>
 #include <setjmp.h>
 #include <cmocka.h>

diff --git a/testing/testsuites/kernel/fs/cases/fs_read_test.c b/testing/testsuites/kernel/fs/cases/fs_read_test.c
@@ -33,7 +33,6 @@
 #include <fcntl.h>
 #include <syslog.h>
 #include <stdint.h>
-#include <stdarg.h>
 #include <stddef.h>
 #include <setjmp.h>
 #include <cmocka.h>

diff --git a/testing/testsuites/kernel/fs/cases/fs_readlink_test.c b/testing/testsuites/kernel/fs/cases/fs_readlink_test.c
@@ -25,7 +25,6 @@
  ****************************************************************************/
 #include <nuttx/config.h>
 #include <errno.h>
-#include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdarg.h>
@@ -34,7 +33,6 @@
 #include <string.h>
 #include <syslog.h>
 #include <stdint.h>
-#include <stdarg.h>
 #include <stddef.h>
 #include <setjmp.h>
 #include <cmocka.h>

diff --git a/testing/testsuites/kernel/fs/cases/fs_sendfile_test.c b/testing/testsuites/kernel/fs/cases/fs_sendfile_test.c
@@ -31,7 +31,6 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <string.h>
-#include <fcntl.h>
 #include <syslog.h>
 #include <stdint.h>
 #include <stdarg.h>

diff --git a/testing/testsuites/kernel/fs/cases/fs_stat_test.c b/testing/testsuites/kernel/fs/cases/fs_stat_test.c
@@ -33,7 +33,6 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <sys/time.h>
-#include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdint.h>

diff --git a/testing/testsuites/kernel/fs/cases/fs_stream_test.c b/testing/testsuites/kernel/fs/cases/fs_stream_test.c
@@ -30,7 +30,6 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <string.h>
-#include <fcntl.h>
 #include <syslog.h>
 #include <stdint.h>
 #include <stdarg.h>

diff --git a/testing/testsuites/kernel/fs/cases/fs_symlink_test.c b/testing/testsuites/kernel/fs/cases/fs_symlink_test.c
@@ -25,13 +25,10 @@
  ****************************************************************************/
 #include <nuttx/config.h>
 #include <errno.h>
-#include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <stdarg.h>
 #include <unistd.h>
 #include <fcntl.h>
-#include <string.h>
 #include <syslog.h>
 #include <stdint.h>
 #include <stdarg.h>

diff --git a/testing/testsuites/kernel/mm/cmocka_mm_test.c b/testing/testsuites/kernel/mm/cmocka_mm_test.c
@@ -27,10 +27,7 @@
 #include <stdarg.h>
 #include <stddef.h>
 #include <stdint.h>
-#include <stdarg.h>
-#include <stddef.h>
 #include <setjmp.h>
-#include <stdint.h>
 #include <stdio.h>
 #include "MmTest.h"
 #include <cmocka.h>

diff --git a/testing/testsuites/kernel/mutex/cmocka_mutex_test.c b/testing/testsuites/kernel/mutex/cmocka_mutex_test.c
@@ -27,10 +27,7 @@
 #include <stdarg.h>
 #include <stddef.h>
 #include <stdint.h>
-#include <stdarg.h>
-#include <stddef.h>
 #include <setjmp.h>
-#include <stdint.h>
 #include <stdio.h>
 #include "MutexTest.h"
 #include <cmocka.h>

diff --git a/testing/testsuites/kernel/pthread/cmocka_pthread_test.c b/testing/testsuites/kernel/pthread/cmocka_pthread_test.c
@@ -27,10 +27,7 @@
 #include <stdarg.h>
 #include <stddef.h>
 #include <stdint.h>
-#include <stdarg.h>
-#include <stddef.h>
 #include <setjmp.h>
-#include <stdint.h>
 #include <stdio.h>
 #include "PthreadTest.h"
 #include <cmocka.h>

diff --git a/testing/testsuites/kernel/socket/cmocka_socket_test.c b/testing/testsuites/kernel/socket/cmocka_socket_test.c
@@ -27,10 +27,7 @@
 #include <stdarg.h>
 #include <stddef.h>
 #include <stdint.h>
-#include <stdarg.h>
-#include <stddef.h>
 #include <setjmp.h>
-#include <stdint.h>
 #include <stdio.h>
 #include "SocketTest.h"
 #include <cmocka.h>

diff --git a/testing/testsuites/kernel/syscall/cases/accept_test.c b/testing/testsuites/kernel/syscall/cases/accept_test.c
@@ -36,8 +36,6 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <errno.h>
-#include <setjmp.h>
-#include <cmocka.h>
 #include <sys/socket.h>
 #include <sys/un.h>
 #include <netinet/in.h>

diff --git a/testing/testsuites/kernel/syscall/cases/bind_test.c b/testing/testsuites/kernel/syscall/cases/bind_test.c
@@ -38,9 +38,7 @@
 #include <cmocka.h>
 #include <grp.h>
 #include <pwd.h>
-#include <sys/types.h>
 #include <syslog.h>
-#include <errno.h>
 #include <pthread.h>
 #include <netinet/in.h>
 

diff --git a/testing/testsuites/kernel/syscall/cases/dup2_test.c b/testing/testsuites/kernel/syscall/cases/dup2_test.c
@@ -27,7 +27,6 @@
 #include <syslog.h>
 #include <stdio.h>
 #include <errno.h>
-#include <syslog.h>
 #include <fcntl.h>
 #include <stdint.h>
 #include <stdarg.h>

diff --git a/testing/testsuites/kernel/syscall/cases/dup_test.c b/testing/testsuites/kernel/syscall/cases/dup_test.c
@@ -27,7 +27,6 @@
 #include <syslog.h>
 #include <stdio.h>
 #include <errno.h>
-#include <syslog.h>
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <stdint.h>

diff --git a/testing/testsuites/kernel/syscall/cases/fsync_test.c b/testing/testsuites/kernel/syscall/cases/fsync_test.c
@@ -28,7 +28,6 @@
 #include <syslog.h>
 #include <unistd.h>
 #include <fcntl.h>
-#include <unistd.h>
 #include <sys/statvfs.h>
 #include <sys/resource.h>
 #include <time.h>
@@ -38,7 +37,6 @@
 #include <sys/stat.h>
 #include <sys/statfs.h>
 #include <sys/types.h>
-#include <sys/resource.h>
 #include <sys/socket.h>
 #include <netinet/in.h>
 #include <stdint.h>

diff --git a/testing/testsuites/kernel/syscall/cases/getTimeofday_test.c b/testing/testsuites/kernel/syscall/cases/getTimeofday_test.c
@@ -29,7 +29,6 @@
 #include <signal.h>
 #include <stdarg.h>
 #include <stdint.h>
-#include <stdarg.h>
 #include <stddef.h>
 #include <setjmp.h>
 #include <cmocka.h>

diff --git a/testing/testsuites/kernel/syscall/cases/lstat_test.c b/testing/testsuites/kernel/syscall/cases/lstat_test.c
@@ -30,7 +30,6 @@
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <stdio.h>
-#include <stdio.h>
 #include <stdint.h>
 #include <stdarg.h>
 #include <stddef.h>

diff --git a/testing/testsuites/kernel/syscall/cases/memcpy_test.c b/testing/testsuites/kernel/syscall/cases/memcpy_test.c
@@ -36,7 +36,6 @@
 #include <stdarg.h>
 #include <stddef.h>
 #include <setjmp.h>
-#include <errno.h>
 #include <cmocka.h>
 #include "SyscallTest.h"