NIFI-13738 Add Max Inbound Message Body Size Property for AMQP #9776
Conversation
exceptionfactory
changed the title
...ifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java
Outdated
Show resolved
Hide resolved
...ifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java
Outdated
Show resolved
Hide resolved
...ifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
In addition to the checkstyle violation mentioned in my previous comment, another comment: right now the new property is added to the common properties in the Abstract class, meaning that the property will also show in the PublishAMQP processor which does not really make sense. I think that it should not be added in PROPERTY_DESCRIPTORS of the Abstract class and instead added in PROPERTY_DESCRIPTORS of the Consume class. Thoughts?
|
It is true that the settings are related to the consumer, but like the port and IP, they must be set in the ConnectionFactory, which is created in the AbstractAMQPProcessor. |
|
The checkstyle validation needs to be fixed. Regarding the property, what I'm saying is that you can remove it from the PROPERTY_DESCRIPTORS list of the Abstract class and be added into the PROPERTY_DESCRIPTORS list of the Consume processor. Everything else remains unchanged. This only affects where the property will be visible in the UI. |
…SCRIPTORS list of the Abstract class and added into the PROPERTY_DESCRIPTORS list of the Consume processor.
setMaxInboundMessageBodySize property would be configurable as a NiFi UI property.