Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13681 Fix Kubernetes coordination environment variable names #9199

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

malthe
Copy link
Contributor

@malthe malthe commented Aug 26, 2024

Summary

NIFI-13681

The Kubernetes-related coordination settings draw on environment variables that do not accurately reflect their property names, leading to confusion.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malthe Thanks for the contribution. I am in favor of this change as it aligns the environment variable name with the property name.

Every change needs a corresponding Apache NiFi Jira issue, so if you can create the Jira issue, then update the pull request title and commit messages with the Jira issue number, this should be ready to go forward.

@malthe malthe changed the title Fix cluster provider environment variable NIFI-13681 Fix Kubernetes coordination environment variable names Aug 26, 2024
@malthe
Copy link
Contributor Author

malthe commented Aug 26, 2024

@exceptionfactory done!

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for linking the Jira issue @malthe! +1 merging

@exceptionfactory exceptionfactory merged commit d9c5a19 into apache:main Aug 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants