NIFI-11270 Refactoring of the overly Paho-specific MQTT interface #7032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lehel44
requested changes
Mar 17, 2023
There was a problem hiding this comment.
Thanks @nandorsoma for the refactor. I left a few comments, overall it looks good to me.
Could you please add documentation to the JIRA ticket about why this refactor is needed.
...le/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/MqttClient.java
Outdated
Show resolved
Hide resolved
...processors/src/main/java/org/apache/nifi/processors/mqtt/adapters/PahoMqttClientAdapter.java
Outdated
Show resolved
Hide resolved
...t-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
Outdated
Show resolved
Hide resolved
|
Thanks for your review @Lehel44! As you requested, I've addressed your comments and added a description to the Jira ticket! |
Lehel44
approved these changes
Mar 22, 2023
turcsanyip
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Thanks for this refactoring @nandorsoma !
Thanks for you review @Lehel44 !
+1 from my side too
Merging to main and 1.x
asfgit
pushed a commit
that referenced
this pull request
Mar 29, 2023
This closes #7032. Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
r-vandenbos
pushed a commit
to r-vandenbos/nifi
that referenced
this pull request
Apr 11, 2023
This closes apache#7032. Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11270
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation