Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist tab order on per-project basis between close/open. #8164

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 17, 2025

  • changed to collections which retain entry order
  • refresh storage on close if order changes

note:

  • opened files are stored per project, re-opening multiple projects will restore the right order within the project but they will be grouped by project as side effect.
  • opened projects might not have a deterministic order since they come right from the lookup (was not the focus of this PR)

fixes #4416

@mbien mbien added Editor ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jan 17, 2025
@mbien mbien added this to the NB25 milestone Jan 17, 2025
@mbien mbien added the UI User Interface label Jan 17, 2025
 - changed to collections which retain entry order
 - refresh storage on close if order changed

note:

opened files are stored per project, re-opening multiple projects will
restore the right order within the project but they will be sorted
by project as side effect.

opened projects might not have a specific order since they
come right from the lookup.
@mbien mbien force-pushed the keep-editor-tab-order branch from 9d282c1 to 6225b37 Compare January 19, 2025 18:44
@mbien
Copy link
Member Author

mbien commented Jan 19, 2025

thanks for review. going to merge since I found an ergonomics related NPE in the same area which can be fixed in a followup PR

@mbien mbien merged commit 235b99a into apache:master Jan 19, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Editor UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep manual sorting of open files when reopening project
3 participants