Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the build output appearance in vscode #8129

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

jhorvath
Copy link
Contributor

@jhorvath jhorvath commented Jan 9, 2025

The output from AbstractLspInputOutputProvider is now displayed in a new terminal in VSCode. However, if the terminal is closed after the build finishes, it does not reappear when the next build is started.
I am addressing this issue by ensuring the terminal is recreated as needed. Additionally, I am modifying the logic so that the outputs for Run, Debug, and Test actions are written to the VSCode Debug Console, as they were previously.

@jhorvath jhorvath added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Jan 9, 2025
@jhorvath jhorvath added this to the NB25 milestone Jan 9, 2025
@jhorvath jhorvath requested a review from sdedic January 9, 2025 10:04
@jhorvath jhorvath self-assigned this Jan 9, 2025
@jhorvath jhorvath added the enterprise [ci] enable enterprise job label Jan 9, 2025
@sdedic
Copy link
Member

sdedic commented Jan 12, 2025

Is there a reason why Run/Debug/Test appears in a Debug window, which is somewhat mixed between NBLS console/debug output and user code I/O and not in something like "Execution" Output window ?

@jhorvath
Copy link
Contributor Author

Is there a reason why Run/Debug/Test appears in a Debug window, which is somewhat mixed between NBLS console/debug output and user code I/O and not in something like "Execution" Output window ?

We want to keep Run/Debug/Test in the Debug window. On the other hand there is no way to get the rest of the outputs (like builds) there is it uses only VScode's debugger infrastructure

Copy link
Member

@sdedic sdedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, definitely an improvement. It would be great to investigate NBLS stdout vs. Run/Debug stdout separation in a future release. Thanks.

@jhorvath jhorvath merged commit eaf4562 into apache:master Jan 13, 2025
32 checks passed
@jhorvath jhorvath deleted the fix-vscode-output branch January 13, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise [ci] enable enterprise job LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants