Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable JDK 23 line-doc comments for now #7907

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Oct 24, 2024

  • codebase has many occurrences of '///' which were never meant to appear in javadoc
  • this disables JDK 23+ "line doc comments" for now (JEP 467)
  • javadoc CI step should run on JDK 23 (like on jenkins) to be able to resolve nb-javac classes (and understand the new flag)
ag -l -E java ///

lists about 1k files, this would be too much work to clean up for little gain atm

targets delivery

 - codebase has many occurrences of '///' which were never meant to
   appear in javadoc this disables JDK 23+ "line doc comments" for now
 - javadoc CI step should run on JDK 23
@mbien mbien added CI continuous integration changes JavaDoc [ci] enable java/javadoc tests and build-javadoc target labels Oct 24, 2024
@mbien mbien added this to the NB24 milestone Oct 24, 2024
Copy link
Contributor

@ebarboni ebarboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thank you.

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Thanks!

@ebarboni ebarboni merged commit f640500 into apache:delivery Nov 5, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration changes JavaDoc [ci] enable java/javadoc tests and build-javadoc target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants