ProcessImplementation module cleanup #7677
Conversation
|
wondering what we should do with the JDK 8 version ide/extexecution.process. It would be good if we could remove it since it won't run in current NB releases + it would also remove two (small) dependencies. Platform apps which depend on it could continue using prior releases of this module from central. |
|
I would replace the code in |
|
mbien
added
ci:dev-build
|
added another commit which:
not sure yet but will probably squash before merge |
| <transformations version="1.0"> | ||
| <transformationgroup> | ||
| <description>Merged o.n.m.extexecution.process.jdk9 into o.n.m.extexecution.process</description> | ||
| <transformation> | ||
| <trigger-dependency type="cancel"> | ||
| <module-dependency codenamebase="org.netbeans.modules.extexecution.process.jdk9"/> | ||
| </trigger-dependency> | ||
| <implies> | ||
| <result> | ||
| <module-dependency codenamebase="org.netbeans.modules.extexecution.process" spec="2.0"/> | ||
| </result> | ||
| </implies> | ||
| </transformation> | ||
| </transformationgroup> | ||
| </transformations> |
There was a problem hiding this comment.
At least looks sane to me, XML validator is happy and the file is registered in the SystemFileSystem.
mbien
added
Upgrade JDK
ide/extexecution.process/manifest.mf
Outdated
| @@ -2,5 +2,5 @@ Manifest-Version: 1.0 | |||
| AutoUpdate-Show-In-Client: false | |||
| OpenIDE-Module: org.netbeans.modules.extexecution.process | |||
| OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/extexecution/process/resources/Bundle.properties | |||
| OpenIDE-Module-Specification-Version: 1.53 | |||
| OpenIDE-Module-Specification-Version: 2.0 | |||
There was a problem hiding this comment.
I have mixed feelings here. On the one hand there is a massive change in the implementation (dependency bump, drop of native implementation), on the other hand the API did not change in any way. This is still marked a compatible change (same major release version), but to me the specification major bump implies different. I would just count it up to 1.54.
There was a problem hiding this comment.
this might sound weird, but i did actually use 1.54 first but then I thought @matthiasblaesing will probably suggest to go to 2.x just to be sure, since it bumps the lang level, the position in the lookup and changes the impl at the same time.
I do think staying on 1.54 should be probably fine too. I have to squash anyway so i can change it if everyone is ok with 1.54.
There was a problem hiding this comment.
going to change it to 1.54 and squash, planning to merge once green
- module can use the API without reflection since build requires JDK 17 by now (impl itself was not altered) - added some logging remove now redundant module - merge ide/extexecution.process.jdk9 into ide/extexecution.process - module-auto-deps.xml should delegate at build time to use the right module
mbien
force-pushed
the
proc-module-cleanup
branch
2 times, most recently
from
3f435c2 to
ffcc646
Compare
small cleanup while debugging #7676