Revert PR #7579 ("Using LSP's ErrorProvider & another attempt at CompletionCollector")

[matthiasblaesing]

Closes: #7647

[jtulach]

If possible, please give me time over the weekend to investigate a different fix than removal of the changes.

[matthiasblaesing]

@jtulach from my POV no problem. This PR is the safety net.

[jtulach]

If

• Opt-in to use ErrorProviderBridge #7659

gets in, then this revert will no longer be needed.

[jtulach]

The problems reported by

• Duplicate text in hint tooltip #7647

are only related to HintsCollector.setError. However the #7579 PR introduces two things:

• HintsCollector.setError
• another attempt at CompletionCollector

there is no point in reverting all. If none of other solutions works (like #7659), then we need to revert only the HintsCollector.setError part and keep the rest. I can prepare such a revert PR during the next 24 h.

[matthiasblaesing]

Lets keep the discussion in #7659.

[ebarboni]

as #7659 is closed maybe continuing discussion here ?
(sorry for delay but not in my place this time) Do not over rely on me.

[mbien]

+1 for NB 23 revert (#7659 (comment) for reasons)

[lahodaj]

FWIW, while I am not particularly happy the bridge between LSP API and client will cease to work for NB 23, I think this should be merged, and we should see if we can achieve the same end goal using a more scalable approach.

While I don't agree with full revert of my changes, I certainly don't want to block decisions of the majority