Minor NBM wizard pom generation fixes and plugin version bumps #7628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Maven
|
I hope CI will pass once edit: fixed now + 14.2 is available |
- maven wizard iterator needed some updates to work better with the new archetypes - bumped the version fallbacks in MavenVersionSettings
mbien
force-pushed
the
nbm-wizard-version-fixes_delivery
branch
from
1669a89 to
4f80c4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing
nbm-maven-plugin14.2, I noticed that the wizard would generate redundant compiler plugins for child poms and it also missed out on some version bumps.This reminded me that the
nbm-archetypeisn't used for anything right now (but this won't fix this).To test this,
nbm-maven-pluginv14.2 andnetbeans-platform-app-archetypev1.24 should be put into the local repo first since they aren't released yet.