Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest of core.output2 to separate the OpenIDE-Module-Provides values with comma #7584

Merged

Conversation

YannLeCorse
Copy link
Contributor

In a Netbeans application based on Maven, the nbm-maven-plugin is failing with the following message while both modules are explicitly part of the application.

[ERROR] Some tokens required by included modules are not provided by included modules. The application will fail starting up. The missing tokens are:
[ERROR]    org.openide.windows.IOProvider          ref: [org.netbeans.modules.css.visual]

Looking at the ExamineManifest source code the nbm-maven-plugin is expecting to find comma separated values.

Looking at the other Manifest on Netbeans source code, it seems that other are comma separated already

Thus core.output2 seems to have a typo addressed by this pull request.

@mbien mbien added Platform [ci] enable platform tests (platform/*) ci:all-tests [ci] enable all tests labels Jul 16, 2024
@mbien mbien added this to the NB23 milestone Jul 16, 2024
@apache apache locked and limited conversation to collaborators Jul 16, 2024
@apache apache unlocked this conversation Jul 16, 2024
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! makes sense to me. enabled all tests to check if fixing the manifest has any side effects.

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i checked and can confirm that all other cases use a comma as separator.

src/org/netbeans/core/output2/NbIOProvider.java is also implementing both providers

all tests green -> merging

@YannLeCorse thanks for fixing this!

@mbien mbien merged commit d93aefd into apache:master Jul 17, 2024
40 checks passed
@YannLeCorse
Copy link
Contributor Author

@YannLeCorse thanks for fixing this!

My one character contribution pleasure.

@YannLeCorse YannLeCorse deleted the core-output2-manifest-missing-comma branch July 30, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-tests [ci] enable all tests Platform [ci] enable platform tests (platform/*)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants