VSNetBeans: Check for source level java compatibility #7555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBalin
changed the title
sdedic
requested changes
Jul 9, 2024
java/java.lsp.server/vscode/src/jdk/validation/extensionUtils.ts
Outdated
Show resolved
Hide resolved
| @@ -184,6 +185,7 @@ function findJDK(onChange: (path : string | null) => void): void { | |||
| } | |||
|
|
|||
| let currentJdk = find(); | |||
| validateJDKCompatibility(currentJdk); | |||
There was a problem hiding this comment.
note -- there's a pending PR #7497 that introduces projectJDK. Depending on which one will merge first, the other PR should change to validate the projectJDK
sdedic
added
Java
|
Do not forget to squash all the commits into a single one before merge. |
|
Please add the license header. |
sdedic
reviewed
Jul 9, 2024
java/java.lsp.server/vscode/src/jdk/validation/extensionUtils.ts
Outdated
Show resolved
Hide resolved
sdedic
approved these changes
Jul 10, 2024
dbalek
approved these changes
Jul 10, 2024
petrovic-d
force-pushed
the
GCN-4643-java-source-level-check
branch
from
bbf760e to
c63fbbc
Compare
sdedic
added
the
do not merge
Get java version from Maven projects
Util for checking if extension command is available
Move file
Get java version from installation path
Project abstraction with methos to retreive java version
Initial position of breakpoints view is next to navigator
Always open expression evaluator view
PHP: removed built-in type real
- deleted the built-in type real
(php does not have a built-in real type: https://www.php.net/manual/en/language.types.intro.php
Also see the warning under "Scalar Types": https://www.php.net/manual/en/language.types.declarations.php)
- fixed broken tests
- new tests added
- fixes generation of return type real instead of float for a method when overriding a base class method with an autocomplete
- fixes generation of return type real instead of float for a function in phpDoc
Fix "Fix Imports" [apacheGH-7546]
- apache#7546
- Compare segments of namespace names to avoid adding incorrect items
- Add a unit test
Reduce redundant cast warnings. These happen as a side result of code cleanup..
Reduce warnings that look like this:
[repeat] /home/bwalker/src/netbeans/enterprise/tomcat5/src/org/netbeans/modules/tomcat5/util/LogManager.java:271: warning: [cast] redundant cast to LogViewer
[repeat] contextLog = (LogViewer)contextLogViewers.get(moduleID);
[repeat] ^Cleanup redundant casts. These are a side effect of work done doing code cleanup.
Fix unit tests
- Use `checkCompletionOnlyDocumentation` test method because there are functions that have the same prefix
Micronaut: Clear symbol cache on ClasspathInfo changes.
Remove downloader from NBI
- the download manager relied on suspend/resume/stop from
java.lang.Thread which were deprecated since Java 1.2
- JDK 23 removes suspend/resume, others are already no-ops
- fixing this would require a completely different approach,
and since NBI is no longer maintained and in the process
to be replaced by nbpackage this is th easiest option
Remove redundant code
Remove new lines
Await on NbLanguageClient
Removed unused code
Reduce number of resolve(undefined)
Explicitly set xml2js parser to be sync
Shorten array element check
Recursively search for subprojects
Reference github issue inside comment
Use vscode.Uri.file
Modify regex to support whitespaces between identifiers, literals and symbols
Use vscode.Uri.parse
Removed explicit check for the command as no longer needed
Add licence header
NBI: disable update check again
- Hide check-for-updates step from the (windows) installer again
since it is a no-op with the current NB release model
- reverts apache#1348 without changing codepaths outside the checkbox
logic to reduce risks of other side effects
- can be re-enabled using a property
Docker - Load images
Docker images don't load because `VirtualSize` attribute was removed from Docker Engine in v1.44.
---
Using `getOrDefault` for the `Created`, `Size` and `VirtualSize` attributes.
Using `Size` as default value to `VirtualSize`.
Annotating the `VirtualSize` attribute as deprecated
CI: start testing on 23-ea
- move from 22 to 23-ea (all except java hints which would require
nb-javac 23)
- merge APISupport job into another job
JDK 23 related test fixes
- '-proc:full' is now required for annotation processing
- java.lang.Thread finally lost a few methods
Improving multistep infrastructure, command for uploading cloud assets to config map
petrovic-d
force-pushed
the
GCN-4643-java-source-level-check
branch
from
c63fbbc to
8b31dac
Compare
|
was about to say that something went wrong during squashing, but this looks better now :) |
sdedic
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature checks if source level java (from the project) is compatible with one used by extension
It ignores check when RH extension is installed
It also works with multi-module projects