Fix formatting for typed field and const alignment #7190 #7423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmysik
reviewed
Jun 4, 2024
php/php.editor/src/org/netbeans/modules/php/editor/indent/FormatVisitor.java
Outdated
Show resolved
Hide resolved
tmysik
reviewed
Jun 4, 2024
php/php.editor/src/org/netbeans/modules/php/editor/indent/FormatVisitor.java
Outdated
Show resolved
Hide resolved
tmysik
approved these changes
Jun 4, 2024
- apache#7190 - Add a field type name length - Fix const name length - Add unit tests Example: ```php class GH7190 { private const ?string C1 = ''; public const ?string CCCC2 = ''; const ?string CCCC3 = ''; private ?Test $t2; private ?Test $t3 = null; private readonly Test1&Test2 $t4; private array|(Test2&Test3) $test5 = []; } ``` Before: ```php class GH7190 { private const ?string C1 = ''; public const ?string CCCC2 = ''; const ?string CCCC3 = ''; private ?Test $t2; private ?Test $t3 = null; private readonly Test1&Test2 $t4; private array|(Test2&Test3) $test5 = []; } ``` After: ```php class GH7190 { private const ?string C1 = ''; public const ?string CCCC2 = ''; const ?string CCCC3 = ''; private ?Test $t2; private ?Test $t3 = null; private readonly Test1&Test2 $t4; private array|(Test2&Test3) $test5 = []; } ```
junichi11
force-pushed
the
php-gh-7190-formatting-for-typed-fields-alignment
branch
from
cce07cb to
f586da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
Before:
After: