Cloud Assets #7413
Merged
Cloud Assets #7413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhorvath
added
LSP
jhorvath
force-pushed
the
cloudassets
branch
3 times, most recently
from
cb9d5b4 to
8dad070
Compare
jhorvath
force-pushed
the
cloudassets
branch
3 times, most recently
from
29ed540 to
cc9f93d
Compare
sdedic
requested changes
Jun 3, 2024
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/OCITenancyProvider.java
Outdated
Show resolved
Hide resolved
...rprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/AddSuggestedItemAction.java
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/AddADBAction.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/AddNewAssetCommand.java
Outdated
Show resolved
Hide resolved
ide/project.dependency/src/org/netbeans/modules/project/dependency/ProjectDependencies.java
Outdated
Show resolved
Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/db/DBConnectionProvider.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/PropertiesGenerator.java
Show resolved
Hide resolved
jhorvath
force-pushed
the
cloudassets
branch
3 times, most recently
from
d4e2314 to
db75575
Compare
sdedic
reviewed
Jun 5, 2024
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/Steps.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/Steps.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/Steps.java
Outdated
Show resolved
Hide resolved
sdedic
approved these changes
Jun 5, 2024
| for (Map.Entry<String, T> entry : ociItems.entrySet()) { | ||
| String description = entry.getValue().getDescription(); | ||
| if (description == null || description.isBlank()) { | ||
| description = title; |
There was a problem hiding this comment.
Just verifying: in case that all items, which have ociItem.getDescription() == null will get the same description (title) - not their ociItem.getName() ?
|
Looks like this broke master - https://github.com/apache/netbeans/actions/runs/9396313092 The test you added seems not to have run on the PR due to incorrect labelling?! |
I'm already aware of that, and the fix is merged with Dusan's PR - https://github.com/apache/netbeans/pull/7439/files#diff-32bd91ec01405d8a4b48b1a52f6cdc7a7faf3c37ff05fb4ad119c2d49a245ce4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a new feature to the VSCode extension: the Cloud Assets Window. This feature is designed to collect and manage Oracle (currently supported) Cloud resources.
Key Features: