Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fold empty arrays #7187 #7398

Merged
merged 1 commit into from
May 24, 2024
Merged

Don't fold empty arrays #7187 #7398

merged 1 commit into from
May 24, 2024

Conversation

junichi11
Copy link
Member

Before:

nb-php-gh-7187-before01

nb-php-gh-7187-before02

After:

nb-php-gh-7187-after01

nb-php-gh-7187-after02

@junichi11
Don't fold empty arrays apache#7187
9520e04 
- apache#7187
- Ignore empty arrays
- Add an unit test
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label May 23, 2024
@junichi11 junichi11 added this to the NB23 milestone May 23, 2024
@junichi11 junichi11 linked an issue May 23, 2024 that may be closed by this pull request
[PHP] Code Folding and empty Arrays #7187
Closed
@junichi11 junichi11 requested a review from tmysik May 23, 2024 10:09
@junichi11 junichi11 merged commit 66c7486 into apache:master May 24, 2024
33 checks passed
@junichi11 junichi11 deleted the php-gh-7187-empty-array-folding branch May 24, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB23
Development

Successfully merging this pull request may close these issues.

[PHP] Code Folding and empty Arrays
2 participants
@junichi11 @tmysik