Fix Exception template to extend from Exception #7390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecified in wizard.
neilcsmith-net
added
Java
matthiasblaesing
approved these changes
May 21, 2024
sid-srini
added a commit
to sid-srini/javavscode
that referenced
this pull request
Aug 27, 2024
In NB23, [patch #7390](apache/netbeans/pull/7390) fixed the regression where the newly created exception from template did not extend Exception, thereby failing to compile. This temporarily backports the fix until NB23 is incorporated. Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
Achal1607
pushed a commit
to oracle/javavscode
that referenced
this pull request
Aug 27, 2024
In NB23, [patch #7390](apache/netbeans/pull/7390) fixed the regression where the newly created exception from template did not extend Exception, thereby failing to compile. This temporarily backports the fix until NB23 is incorporated. Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Exception template to extend from Exception when no superclass specified in wizard. It's a minor annoyance but odd to have a built-in template create uncompilable code by default.
Theoretically this is a regression, although it seems to have been there since this was last updated for NB 12.3 in #2275 !