HCL: fix possible NPE-s, in List.of() and asString() #7286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
reviewed
Apr 22, 2024
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLExpression.java
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLFunction.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLResolveOperation.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLResolveOperation.java
Outdated
Show resolved
Hide resolved
lkishalmi
force-pushed
the
languages.hcl-npe-improvements
branch
from
383ffa3 to
68591ff
Compare
mbien
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, it seems NPE-s can happen if
List.of()has anullargument, and sometimes incomplete language elements can evaluate tonull.Also fixed
asString()methods as that was relying too much ontoString()methods which is not auto-generated with records.Added a bunch of simple unit-tests as well.