PHP: Improved validation of rename refactoring #7273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nitpick: Actually, I don't like that we are opening the panel already with an error (it means that the user did not do any change yet but still, there is already an error); personally, I would prefer to have the Preview button disabled (possibly with an info message of type "do your change here"). |
I haven't looked into it much, but it looks like you need to edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rename refactoring, element name validation occurs only when the name is changed, which can lead to a situation like in #6531.
This PR adds element name validation when opening the rename refactoring window.
Before:
before_php_rename_refactoring.mp4
After:
after_php_rename_refactoring.mp4