Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCL added Scoped Function name support (Terraform 1.8) #7270

Merged
merged 1 commit into from
Apr 16, 2024
Merged

HCL added Scoped Function name support (Terraform 1.8) #7270

merged 1 commit into from
Apr 16, 2024

Conversation

lkishalmi
Copy link
Contributor

Well, a small change, I hope I've done that right.

@lkishalmi lkishalmi added the HCL label Apr 15, 2024
@lkishalmi lkishalmi added this to the NB22 milestone Apr 15, 2024
vieiro
vieiro approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@vieiro vieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test anytime soon, but changes look correct to me!

matthiasblaesing
matthiasblaesing reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me, though I only eyeballed the change and not a terraform user myself.

@lkishalmi lkishalmi merged commit 8c75f2d into apache:master Apr 16, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vieiro vieiro vieiro approved these changes

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

@mbien mbien Awaiting requested review from mbien

Assignees
No one assigned
Labels
HCL
Projects
None yet
Milestone
NB22
Development

Successfully merging this pull request may close these issues.
3 participants
@lkishalmi @vieiro @matthiasblaesing