Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Groovy Application/Library Project Creation Wizards #7258

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

lkishalmi
Copy link
Contributor

This one depends on #7257 and has to be rebased on that once merged.

Though it is just a low hanging fruit to add Groovy project creation.

image

image

@lkishalmi lkishalmi added Groovy Gradle [ci] enable "build tools" tests labels Apr 11, 2024
@lkishalmi lkishalmi added this to the NB22 milestone Apr 11, 2024
@lkishalmi lkishalmi force-pushed the gradle-groovy-project-wizard branch from 0125e7a to 0cfda61 Compare April 13, 2024 05:32
@lkishalmi lkishalmi marked this pull request as ready for review April 13, 2024 06:12
@lkishalmi
Copy link
Contributor Author

Should the category be "Groovy with Gradle"?

@mbien
Copy link
Member

mbien commented Apr 14, 2024

Should the category be "Groovy with Gradle"?

would make sense I think.

@lkishalmi lkishalmi force-pushed the gradle-groovy-project-wizard branch from 0cfda61 to 540c9d0 Compare April 14, 2024 20:56
@lkishalmi
Copy link
Contributor Author

Screenshot from 2024-04-14 13-54-47

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! not tested but code+screenshot makes sense to me

I assume this will properly activate the groovy cluster, right? ;)

@ebarboni ebarboni modified the milestones: NB22, NB23 Apr 19, 2024
@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Jun 26, 2024
@lkishalmi lkishalmi force-pushed the gradle-groovy-project-wizard branch from 540c9d0 to 98f316c Compare July 17, 2024 00:20
@lkishalmi lkishalmi requested a review from mbien July 17, 2024 00:21
@lkishalmi lkishalmi force-pushed the gradle-groovy-project-wizard branch from 98f316c to e3d27ba Compare July 17, 2024 00:22
@mbien
Copy link
Member

mbien commented Jul 17, 2024

seems to work. Although on first attempt it didn't seem to work. Since the wizard doesn't check if the project already exists, so I created a new groovy project but it opened the existing gradle project I had in /tmp and i was confused why it made a java project :)

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay, looks good.

we have to add project name validation at some point though, since the wizard could overwrite someone's project like it happened to me during testing.

@lkishalmi lkishalmi merged commit 8dfbb29 into apache:master Jul 17, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Gradle [ci] enable "build tools" tests Groovy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants