Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions after incompatible changes in versioning.util and mercurial #7230

Merged

Conversation

matthiasblaesing
Copy link
Contributor

  • Incompatible changes in the API of a module should not only bump the major part of the specification version, but also the release version of the module, which is reflected in the manifest as MODULENAME/RELEASEVERSION
  • All modules depending on a module that is incompatibly changed need to be updated and their specification version needs to be updated so that they are covered by autoupdate.

…curial

- Incompatible changes in the API of a module should not only bump
  the major part of the specification version, but also the release
  version of the module, which is reflected in the manifest as
  MODULENAME/RELEASEVERSION
- All modules depending on a module that is incompatibly changed need
  to be updated and their specification version needs to be updated
  so that they are covered by autoupdate.
@matthiasblaesing matthiasblaesing added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Apr 2, 2024
@matthiasblaesing matthiasblaesing added this to the NB22 milestone Apr 2, 2024
@matthiasblaesing matthiasblaesing requested a review from mbien April 2, 2024 21:02
@mbien
Copy link
Member

mbien commented Apr 2, 2024

thanks for fixing this. The surprising thing to me however is that NB is updating modules automatically during activation without asking. This is something we should be aware off while testing dev builds since the results may not be what one would expect if master is ahead of the PR which was the case here.

@matthiasblaesing matthiasblaesing merged commit b70fb8b into apache:master Apr 3, 2024
34 checks passed
@mbien mbien added subversion [ci] enable versioning job git [ci] enable versioning job mercurial [ci] aka hg; enable versioning job labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) git [ci] enable versioning job mercurial [ci] aka hg; enable versioning job subversion [ci] enable versioning job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants