Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSF 1.2 from Libraries #7184

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

lkishalmi
Copy link
Contributor

This PR removes JSF 1.2 from Tools > Libraries.

JSF 1.2 has been released in 2006 (18 years ago), No one suppose to create a new Ant (or Maven)project with it.
We have JSF 2.3 in the libraries.

The jsf12 module came up while checking the module for #7117

@lkishalmi lkishalmi added this to the NB22 milestone Mar 24, 2024
@mbien mbien added the enterprise [ci] enable enterprise job label Mar 24, 2024
@mbien
Copy link
Member

mbien commented Mar 24, 2024

glad to see more cleanups, fits right into the theme of #6994 + #6987

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only eyeballed this, but reasoning is sound and change looks good to me.

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to approve

@lkishalmi lkishalmi merged commit 813c07c into apache:master Mar 25, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code cleanup enterprise [ci] enable enterprise job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants