Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default Git Hyperlink Provider. #7147

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Add default Git Hyperlink Provider. #7147

merged 1 commit into from
Mar 19, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Mar 10, 2024 •
edited
Loading

  • matches PR/issue IDs and links them to a fitting web page.
  • the project host is identified by inspecting the registered remote branches of the local repo.
  • tested with github and gitlab projects from different hosts

This will work as long no task repository is defined under services, since those would have higher priority and take over.

screenshot:
git-pr-links

@mbien mbien added UI User Interface git [ci] enable versioning job labels Mar 10, 2024
@mbien mbien added this to the NB22 milestone Mar 10, 2024
@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Mar 16, 2024
@mbien mbien marked this pull request as ready for review March 16, 2024 01:07
@mbien mbien requested a review from lkishalmi March 16, 2024 01:16
@mbien
Copy link
Member Author

mbien commented Mar 18, 2024

incorporated reviewer comments:

@mbien mbien removed the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Mar 18, 2024
@mbien
Copy link
Member Author

mbien commented Mar 18, 2024

@junichi11 ok to merge?

@mbien
Copy link
Member Author

mbien commented Mar 19, 2024

going to merge so that I can easier test interactions with a rebased #7128

lkishalmi
lkishalmi approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me!

@mbien
Add default Git Hyperlink Provider.
a904045 
 - matches PR/issue IDs and links them to the fitting web page
 - the repo host is identified by inspecting the registered remotes
 - tested with github and several gitlab instances
@mbien mbien merged commit fb27f74 into apache:master Mar 19, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junichi11 junichi11 junichi11 left review comments

@lkishalmi lkishalmi lkishalmi approved these changes

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

@neilcsmith-net neilcsmith-net Awaiting requested review from neilcsmith-net

Assignees
No one assigned
Labels
git [ci] enable versioning job UI User Interface
Projects
None yet
Milestone
NB22
Development

Successfully merging this pull request may close these issues.
5 participants
@mbien @junichi11 @lkishalmi @matthiasblaesing @neilcsmith-net