Made HCL AST on records #7097
Merged
Made HCL AST on records #7097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasblaesing
approved these changes
Feb 29, 2024
|
@matthiasblaesing could you share your opinions? I've always valued your wisdom. This Java 17 and records a bit new to me, so I'm eager to see other opinions as well. |
mbien
reviewed
Feb 29, 2024
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLContainer.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLContainer.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLArithmeticOperation.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLElement.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/HCLSemanticAnalyzer.java
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLTreeWalker.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/test/unit/src/org/netbeans/modules/languages/hcl/HCLIndenterTest.java
Outdated
Show resolved
Hide resolved
lkishalmi
force-pushed
the
languages.hcl-ast-take-2
branch
from
f016a1b to
a4d90c8
Compare
mbien
reviewed
Mar 13, 2024
There was a problem hiding this comment.
looked through it in NB (which is so much nicer than here on github), looks good overall, left some comments.
a jackpot rule matched at SourceRef L74-75 which is outside the area github lets me comment on. It can be simplified to:
for (Map.Entry<OffsetRange, HCLElement> e : elementAt.entrySet()) {
Comment on lines
+36
to
37
| public List<? extends HCLExpression> elements() { | ||
| return Arrays.asList(condition, trueValue, falseValue); |
There was a problem hiding this comment.
List.ofwould make this immutable and better compatible with List.copyOf which I saw somewhere else. Another match would be in HCLLanguage L236.
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLBlock.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLTreeWalker.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLTreeWalker.java
Outdated
Show resolved
Hide resolved
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/HCLSemanticAnalyzer.java
Outdated
Show resolved
Hide resolved
mbien
reviewed
Mar 13, 2024
ide/languages.hcl/test/unit/src/org/netbeans/modules/languages/hcl/HCLIndenterTest.java
Outdated
Show resolved
Hide resolved
mbien
approved these changes
Mar 17, 2024
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/ast/HCLContainer.java
Outdated
Show resolved
Hide resolved
lkishalmi
force-pushed
the
languages.hcl-ast-take-2
branch
2 times, most recently
from
cd0c2d2 to
34f49d7
Compare
Use TextBlocks in formatting test, minor enhancements
lkishalmi
force-pushed
the
languages.hcl-ast-take-2
branch
from
34f49d7 to
4e52a8d
Compare
|
this is causing graal tests to fail since they run on EOL JDK 11 graalvm, but I think i found a way to temp fix this without revert. Testing it locally atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well,
I've been waiting for this. I think this is an improvement comparing to the previous version at least for reading. The implementation is more safe.
Performance vise it might be worse than before, though I have no tests to prove that.
Anyway, tests are passing.
Now I'm waiting for Java 21 and it's record patterns.