Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect code completion for use function #7041 #7054

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Fix incorrect code completion for use function #7041 #7054

merged 1 commit into from
Feb 11, 2024

Conversation

junichi11
Copy link
Member

@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Feb 11, 2024
@junichi11 junichi11 added this to the NB22 milestone Feb 11, 2024
@junichi11 junichi11 linked an issue Feb 11, 2024 that may be closed by this pull request
Code completion for use function is incorrect #7041
Closed
@junichi11 junichi11 requested a review from tmysik February 11, 2024 05:32
@junichi11
Fix incorrect code completion for use function apache#7041
e6cbcb2 
- apache#7041
- Don't add parameter parts if the context is use functions
- Add unit tests
@junichi11 junichi11 force-pushed the php-gh-7041-formatting-use-function branch from 3d9735f to e6cbcb2 Compare February 11, 2024 11:03
@junichi11 junichi11 merged commit ffd958e into apache:php-nb22-features Feb 11, 2024
34 checks passed
@junichi11 junichi11 deleted the php-gh-7041-formatting-use-function branch February 11, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB22
Development

Successfully merging this pull request may close these issues.

Code completion for use function is incorrect
2 participants
@junichi11 @tmysik