Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to open Preview Design window on Mac OS X and Windows #7026

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Unable to open Preview Design window on Mac OS X and Windows #7026

merged 1 commit into from
Feb 6, 2024

Conversation

brunogptavares
Copy link
Contributor

Correction for the issue, unable to open Preview Design window on Mac OS X and Windows #7007.

@mbien mbien linked an issue Feb 4, 2024 that may be closed by this pull request
Unable to open Preview Design window on Mac OS X #7007
Closed
@mbien mbien added UI User Interface os:macos os:windows FormDesigner GUI builder, also known as Matisse labels Feb 4, 2024
@mbien
Copy link
Member

mbien commented Feb 5, 2024 •
edited
Loading

hi @brunogptavares, thanks for looking into this and opening a PR.

would you mind moving your commit on top of the delivery branch and to force push into your PR branch? This would be a candidate to make it into NetBeans 21 which is in the release phase atm. If it stays as is it would target NB 22.

@mbien mbien added ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) ci:all-tests [ci] enable all tests labels Feb 5, 2024
@neilcsmith-net neilcsmith-net added this to the NB21 milestone Feb 6, 2024
@neilcsmith-net neilcsmith-net added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Feb 6, 2024
@neilcsmith-net
Copy link
Member

neilcsmith-net commented Feb 6, 2024 •
edited
Loading

@mbien is looking to rebase and merge this to delivery for rc3. Label until it's rebased, just in case.

@mbien mbien changed the base branch from master to delivery February 6, 2024 18:20
@mbien mbien force-pushed the unable-to-open-preview-design-window branch from e761fd7 to e9ef873 Compare February 6, 2024 18:20
@mbien mbien removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Feb 6, 2024
@mbien
Copy link
Member

mbien commented Feb 6, 2024

done. moved ontop of latest delivery and force pushed

@mbien
Copy link
Member

mbien commented Feb 6, 2024 •
edited
Loading

timeout in core.startup https://github.com/apache/netbeans/actions/runs/7804306564/job/21286386378?pr=7026

restarting. never seen that before.

second run worked, restarting again just to be sure -> green again

@brunogptavares
Copy link
Contributor Author

Hi @mbien thanks for doing the merge, I didn't quite understand what I was supposed to do with the PR.

@mbien mbien merged commit 8a08acc into apache:delivery Feb 6, 2024
39 checks passed
@mbien
Copy link
Member

mbien commented Feb 6, 2024

@brunogptavares no worries. Congrats to your first contribution!

@mbien
Copy link
Member

mbien commented Feb 6, 2024 •
edited
Loading

@neilcsmith-net the timeout happened again, this time post merge:
https://github.com/apache/netbeans/actions/runs/7805764810/attempts/1

    [junit] Testsuite: org.netbeans.core.startup.InstallTmpModuleTest

in both cases. Happened twice out of 6 runs.

edit: tests work locally too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbien mbien

Labels
ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) FormDesigner GUI builder, also known as Matisse os:macos os:windows UI User Interface
Projects
None yet
Milestone
NB21
Development

Successfully merging this pull request may close these issues.

Unable to open Preview Design window on Mac OS X
3 participants
@brunogptavares @mbien @neilcsmith-net