Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling libs.nbjavacapi for debugger.jpda.truffle tests. #6953

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jan 15, 2024

Before #6743 nb-javac was always enabled when it was installed and when java.source.base was enabled, due to OpenIDE-Module-Recommends: org.netbeans.libs.nbjavac in java.source.base's manifest.

This entry has been removed in 6743, which appears to break debugger.jpda.truffle tests. This is an attempt to fix that, by explicitly enabling libs.nbjavacapi in the test.

@lahodaj lahodaj added the ci:all-tests [ci] enable all tests label Jan 15, 2024
@lahodaj lahodaj added this to the NB21 milestone Jan 15, 2024
Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and appears to have addressed the issue.

@lahodaj lahodaj merged commit 9762c8e into apache:master Jan 15, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-tests [ci] enable all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants