Update Gradle Tooling API to 8.6 #6926
Conversation
lkishalmi
added
Gradle
And if it isn't, do we wait on it?? Making the IDE 8.6 aware is a good thing. But the tooling API is meant to be forwards compatible. What do we have that won't work with 8.6 even if we ship with 8.5 of the tooling API? |
|
Well, I'm about to update the New Gradle project wizard and use: https://docs.gradle.org/8.6-rc-1/release-notes.html#generating-without-interactive-questions Not strictly necessary, though... |
|
Please wait with integration until the "Apache NBLS" release in the next few days, in case something screws up (as always). Thanks. |
|
how can there be a release 5 days before NB feature freeze? There is no wiggle room to delay pending NetBeans PRs right now. They have to get in this weekend or they will miss NB 21. |
Sorry; I didn't match the different schedules right. I didn't meantto request a feature slip, the |
There was a problem hiding this comment.
- I have no opinion on (potentially) releasing with 8.6rc-1.
- We need to plan testing in NBLS area during feature freeze. Our 'sample projects' are usually affected by gradle changes -> @MartinBalin
|
Well, I don't know why we're releasing a VSNetBeans release at the same time as 21-rc1, but that's a discussion for dev@ where it should have happened in the first place ... On this change, @lkishalmi if there's a good reason to bring in an rc of Gradle tooling then go ahead IMO. As long as it doesn't "leak" into the UI I don't see a problem. ie. like the use of |
|
VSNetBeans 20.0.301 is branched and being released. There is no problem with this PR making it to 21. If it breaks something issue will be filed. Svata just mentioned we have to test Gradle projects carefully during 21 testing as these are breaking more easily than Maven.... |
|
Well, is there a list of which areas of Gradle support are Tooling API version dependent? In theory the tooling API version shouldn't have an effect on projects. If we can communicate to testers during rc phase which features are dependent, we could potentially focus testing on upgrades? |
lkishalmi
force-pushed
the
gradle-tooling-api-8.6-rc-1
branch
from
fb75624 to
41afde9
Compare
|
Above: NetBeans 21-rc2 running a Java 21 Project with Gradle 8.6, where the Java Runtime for Gradle is Java 17. Below: This PR running a Java 21 Project with Gradle 8.6, while the Java Runtime for Gradle is Java 21.
|
lkishalmi
changed the title
And how about running 21-rc2 with the IDE and Gradle runtime set to Java 21? I'm not against merging this change, even so late. Running on a clean userdir, a new Gradle project is currently set up with 8.5, and I presume will pick up 8.6 as and when the Gradle people designate it |
|
It has to be tested with latest micronaut-core which is the ultimate test for Gradle all the time. |
|
@MartinBalin I intend to merge this after #7029 unless you have specific concerns now? Are there test micronaut-core projects to consider / look at? Note that this shouldn't change the version of Gradle used in those projects, unless they don't use the wrapper? |
|
Yes, can be merged. |
It's quite possible that Gradle 8.6 would be released before NB21, so let's start the upgrade now, and maybe add another PR for the final 8.6 during the RC cycle.